Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gc-eu-mq-dbg seems to be an additonal directory that is breaking the decomp build #305

Open
kevin192291 opened this issue Feb 2, 2024 · 3 comments

Comments

@kevin192291
Copy link

It seems the decomp file now has a directory within the build folder called gc-eu-mq-dbg
This seems to be breaking fast64's exports. I think this needs to be updated, I am very new to this and
am not sure if I am correct here, but after I export a scene I need to copy the contents of gc-eu-mq-dbg into
build (along side gc-eu-mq-dbg), and everything builds again.

If I am on the correct track, Let me know and I would love to try to fix this :)

@Yanis42
Copy link
Contributor

Yanis42 commented Feb 2, 2024

yeah this is a known issue, I'm not making it my top priority as you can use a workaround with the "custom export path" checkbox, it won't edit spec and scene_table for you but at least it will work for sure which the important part here imo

if you wanna fix it you need to change stuff here I think (I haven't dig into this but afaik the spec file is the only broken thing right now)

Note that I plan to work on a fix once I get the HackerOoT rework done, which should happen soonish™™™, feel free to work on it, just let me know

and of course feel free to ask questions or anything else on Fast64's Discord, it will be easier to communicate on this from Discord

@Yanis42
Copy link
Contributor

Yanis42 commented Feb 2, 2024

also the fix is just replacing build/ by $(BUILD)/ I believe (in the file I linked)

@Dragorn421
Copy link
Contributor

Another workaround is editing the Makefile this way, so build/ as written by fast64 is replaced with build/gc-eu-mq-dbg/ on processing the spec:

diff --git a/Makefile b/Makefile
index a8869f3fe..6da61a684 100644
--- a/Makefile
+++ b/Makefile
@@ -125,10 +125,10 @@ PYTHON     ?= $(VENV)/bin/python3
 
 # Command to replace path variables in the spec file. We can't use the C
 # preprocessor for this because it won't substitute inside string literals.
-SPEC_REPLACE_VARS := sed -e 's|$$(BUILD_DIR)|$(BUILD_DIR)|g'
+SPEC_REPLACE_VARS := sed -e 's|build/|$(BUILD_DIR)/|g' | sed -e 's|$$(BUILD_DIR)|$(BUILD_DIR)|g'
 
 ifeq ($(COMPILER),gcc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants