Minor code improvements - WIP #208
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uprendis
reviewed
Dec 23, 2021
uprendis
reviewed
Dec 23, 2021
uprendis
reviewed
Dec 23, 2021
uprendis
reviewed
Dec 23, 2021
uprendis
reviewed
Dec 23, 2021
uprendis
reviewed
Dec 23, 2021
uprendis
reviewed
Dec 23, 2021
uprendis
reviewed
Dec 23, 2021
gossip/emitter/emitter.go
Outdated
| // short circuit if not a validator | ||
| return nil, nil | ||
| } | ||
| sortedTxs := em.getSortedTxs() | ||
|
|
||
| if em.world.IsBusy() { |
There was a problem hiding this comment.
It may make sense to leave the check closer to em.world.Lock() to reduce the chance of locking the mutex when there's an active block processing. The reason why we bother with IsBusy check is because em.world.Lock will lock engine mutex and then wait until block processing is complete (if any). That will make engine mutex unavailable while we're waiting for completion of block processing (in a case if it's running)
There was a problem hiding this comment.
I get your point. Reverting my changes.
uprendis
reviewed
Dec 23, 2021
cyberbono3
force-pushed
the
london-snapsync-code-review
branch
from
64c315a
to
6f651f8
Compare
cyberbono3
force-pushed
the
london-snapsync-code-review
branch
from
5b88a47
to
08aeb74
Compare
|
@uprendis I have addressed your comments. I will continue working on it as soon as I have compete tasks with higher priority. Let us leave in draft for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.