Fix: Do not use `static` in callables #785

localheinz · 2023-09-25T16:37:51Z

What is the reason for this PR?

stops using static in callables

Fixes #784.
Follows #479.

Author's checklist

Follow the Contribution Guide

Summary of changes

Review checklist

All checks have passed
Changes are added to the CHANGELOG.md
Changes are approved by maintainer

localheinz · 2023-09-25T16:47:41Z

test/Faker/Provider/pt_BR/PhoneNumberTest.php

+        self::assertIsString($phoneNumber);
+        self::assertNotEmpty($phoneNumber);


These tests are not very useful other than letting us see whether we still trigger any deprecations here.

bram-pkg

LGTM, thanks @localheinz

localheinz · 2023-09-26T11:29:03Z

Thank you, @bram-pkg!

* Fix: Add tests * Fix: Do not use static in callables

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [fakerphp/faker](https://togithub.com/FakerPHP/Faker) | `1.23.0` -> `1.23.1` | [![age](https://developer.mend.io/api/mc/badges/age/packagist/fakerphp%2ffaker/1.23.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/packagist/fakerphp%2ffaker/1.23.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/packagist/fakerphp%2ffaker/1.23.0/1.23.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/packagist/fakerphp%2ffaker/1.23.0/1.23.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>FakerPHP/Faker (fakerphp/faker)</summary> ### [`v1.23.1`](https://togithub.com/FakerPHP/Faker/releases/tag/v1.23.1) [Compare Source](https://togithub.com/FakerPHP/Faker/compare/v1.23.0...v1.23.1) #### What's Changed - fix typos: "assymetric" -> asymmetric by [@ivastly](https://togithub.com/ivastly) in [FakerPHP/Faker#660 - Fix: lv_LV postcode format by [@edgarsn](https://togithub.com/edgarsn) in [FakerPHP/Faker#661 - composer(deps): bump vimeo/psalm from 5.12.0 to 5.13.1 in /vendor-bin/psalm by [@dependabot](https://togithub.com/dependabot) in [FakerPHP/Faker#669 - composer(deps): bump rector/rector from 0.17.0 to 0.17.2 in /vendor-bin/rector by [@dependabot](https://togithub.com/dependabot) in [FakerPHP/Faker#667 - composer(deps): bump phpstan/phpstan from 1.10.15 to 1.10.22 in /vendor-bin/phpstan by [@dependabot](https://togithub.com/dependabot) in [FakerPHP/Faker#666 - composer(deps): bump friendsofphp/php-cs-fixer from 3.17.0 to 3.20.0 in /vendor-bin/php-cs-fixer by [@dependabot](https://togithub.com/dependabot) in [FakerPHP/Faker#668 - Add `$format` to `image` DocBlock by [@vintagesucks](https://togithub.com/vintagesucks) in [FakerPHP/Faker#670 - Fix: lv_LV generating invalid personal identity numbers by [@edgarsn](https://togithub.com/edgarsn) in [FakerPHP/Faker#663 - Fix for polish street names + more polish TLDs by [@tomaszklim](https://togithub.com/tomaszklim) in [FakerPHP/Faker#664 - Fix psalm baseline in .gitattributes by [@VincentLanglet](https://togithub.com/VincentLanglet) in [FakerPHP/Faker#674 - composer(deps): bump rector/rector from 0.17.2 to 0.17.7 in /vendor-bin/rector by [@dependabot](https://togithub.com/dependabot) in [FakerPHP/Faker#676 - composer(deps): bump phpstan/phpstan from 1.10.22 to 1.10.26 in /vendor-bin/phpstan by [@dependabot](https://togithub.com/dependabot) in [FakerPHP/Faker#677 - composer(deps): bump friendsofphp/php-cs-fixer from 3.20.0 to 3.22.0 in /vendor-bin/php-cs-fixer by [@dependabot](https://togithub.com/dependabot) in [FakerPHP/Faker#679 - composer(deps): bump vimeo/psalm from 5.13.1 to 5.14.1 in /vendor-bin/psalm by [@dependabot](https://togithub.com/dependabot) in [FakerPHP/Faker#678 - chore: ensure php 8.3 compatibility by [@Chris53897](https://togithub.com/Chris53897) in [FakerPHP/Faker#684 - Remove invalid postcode pattern for France by [@ker0x](https://togithub.com/ker0x) in [FakerPHP/Faker#683 - Fix: Allow tests to fail on PHP 8.3 by [@localheinz](https://togithub.com/localheinz) in [FakerPHP/Faker#693 - Fix: Test does not perform any assertions by [@localheinz](https://togithub.com/localheinz) in [FakerPHP/Faker#695 - Fix: Operator by [@localheinz](https://togithub.com/localheinz) in [FakerPHP/Faker#696 - Fix: Use boolean expressions by [@localheinz](https://togithub.com/localheinz) in [FakerPHP/Faker#697 - composer(deps): bump rector/rector from 0.17.7 to 0.18.1 in /vendor-bin/rector by [@dependabot](https://togithub.com/dependabot) in [FakerPHP/Faker#688 - composer(deps): bump phpstan/phpstan from 1.10.26 to 1.10.32 in /vendor-bin/phpstan by [@dependabot](https://togithub.com/dependabot) in [FakerPHP/Faker#689 - composer(deps): bump vimeo/psalm from 5.14.1 to 5.15.0 in /vendor-bin/psalm by [@dependabot](https://togithub.com/dependabot) in [FakerPHP/Faker#687 - composer(deps): bump phpstan/phpstan-deprecation-rules from 1.1.3 to 1.1.4 in /vendor-bin/phpstan by [@dependabot](https://togithub.com/dependabot) in [FakerPHP/Faker#690 - composer(deps): bump friendsofphp/php-cs-fixer from 3.22.0 to 3.25.0 in /vendor-bin/php-cs-fixer by [@dependabot](https://togithub.com/dependabot) in [FakerPHP/Faker#686 - Fix: Require to pass name to `ContainerBuilder::add()` by [@localheinz](https://togithub.com/localheinz) in [FakerPHP/Faker#702 - Enhancement: Run tests in random order by [@localheinz](https://togithub.com/localheinz) in [FakerPHP/Faker#701 - Fix: Add property type declarations by [@localheinz](https://togithub.com/localheinz) in [FakerPHP/Faker#699 - Fix: Enable and configure `type_declaration_spaces` instead of deprecated `function_typehint_space` fixer by [@localheinz](https://togithub.com/localheinz) in [FakerPHP/Faker#698 - composer(deps): bump phpstan/phpstan from 1.10.32 to 1.10.33 in /vendor-bin/phpstan by [@dependabot](https://togithub.com/dependabot) in [FakerPHP/Faker#704 - composer(deps): bump friendsofphp/php-cs-fixer from 3.25.0 to 3.25.1 in /vendor-bin/php-cs-fixer by [@dependabot](https://togithub.com/dependabot) in [FakerPHP/Faker#705 - github-actions(deps): bump actions/checkout from 3 to 4 by [@dependabot](https://togithub.com/dependabot) in [FakerPHP/Faker#706 - Fix: Switch order of parameters by [@localheinz](https://togithub.com/localheinz) in [FakerPHP/Faker#703 - Fix: Remove unused method by [@localheinz](https://togithub.com/localheinz) in [FakerPHP/Faker#711 - Fix: Rename parameter by [@localheinz](https://togithub.com/localheinz) in [FakerPHP/Faker#707 - Fix: Add parameter type declaration by [@localheinz](https://togithub.com/localheinz) in [FakerPHP/Faker#710 - Fix: Order by [@localheinz](https://togithub.com/localheinz) in [FakerPHP/Faker#712 - Enhancement: Reuse `NumberExtension` by [@localheinz](https://togithub.com/localheinz) in [FakerPHP/Faker#715 - Fix: Methods are instance methods by [@localheinz](https://togithub.com/localheinz) in [FakerPHP/Faker#708 - Fix: Add property type declarations by [@localheinz](https://togithub.com/localheinz) in [FakerPHP/Faker#713 - Fix: Reduce visibility by [@localheinz](https://togithub.com/localheinz) in [FakerPHP/Faker#714 - Fix: Do not memoize invalid service by [@localheinz](https://togithub.com/localheinz) in [FakerPHP/Faker#709 - Fix: Consistently describe experimental status by [@localheinz](https://togithub.com/localheinz) in [FakerPHP/Faker#717 - Fix: Mark classes as experimental by [@localheinz](https://togithub.com/localheinz) in [FakerPHP/Faker#716 - Fix: Mark class as `final` by [@localheinz](https://togithub.com/localheinz) in [FakerPHP/Faker#718 - Fix: Return string by [@localheinz](https://togithub.com/localheinz) in [FakerPHP/Faker#726 - Fix: Order by [@localheinz](https://togithub.com/localheinz) in [FakerPHP/Faker#722 - Fix: Avoid unnecessary imports by [@localheinz](https://togithub.com/localheinz) in [FakerPHP/Faker#721 - Enhancement: Enable `self_static_accessor` fixer by [@localheinz](https://togithub.com/localheinz) in [FakerPHP/Faker#728 - Fix: Cache for `friendsofphp/php-cs-fixer` by [@localheinz](https://togithub.com/localheinz) in [FakerPHP/Faker#729 - Fix: Add parameter type declarations by [@localheinz](https://togithub.com/localheinz) in [FakerPHP/Faker#724 - Fix: Add tests for `Container` by [@localheinz](https://togithub.com/localheinz) in [FakerPHP/Faker#727 - Fix: Simplify by [@localheinz](https://togithub.com/localheinz) in [FakerPHP/Faker#720 - updated polish license plates by [@scybulski](https://togithub.com/scybulski) in [FakerPHP/Faker#685 - Fix: Update `CHANGELOG.md` by [@localheinz](https://togithub.com/localheinz) in [FakerPHP/Faker#734 - Fix: Avoid useless tests for `ContainerBuilder` by [@localheinz](https://togithub.com/localheinz) in [FakerPHP/Faker#730 - Fix: Rename parameter by [@localheinz](https://togithub.com/localheinz) in [FakerPHP/Faker#731 - Add changelog mention in review checklist by [@bram-pkg](https://togithub.com/bram-pkg) in [FakerPHP/Faker#735 - Enhancement: Allow creating `ContainerBuilder` with definitions for default extensions by [@localheinz](https://togithub.com/localheinz) in [FakerPHP/Faker#732 - Fix: Reduce visibility by [@localheinz](https://togithub.com/localheinz) in [FakerPHP/Faker#719 - Fix: Remove unused method by [@localheinz](https://togithub.com/localheinz) in [FakerPHP/Faker#736 - Enhancement: Add `SECURITY.md` by [@localheinz](https://togithub.com/localheinz) in [FakerPHP/Faker#739 - Fix: Do not use `static` in callables by [@localheinz](https://togithub.com/localheinz) in [FakerPHP/Faker#785 - Fixed incorrect female name among male names ([#794](https://togithub.com/FakerPHP/Faker/issues/794)) by [@pimjansen](https://togithub.com/pimjansen) in [FakerPHP/Faker#795 - Removed suppressed State from it_IT by [@BoGnY](https://togithub.com/BoGnY) in [FakerPHP/Faker#802 - Update Address.php to fix country name errors by [@supgeek-rod](https://togithub.com/supgeek-rod) in [FakerPHP/Faker#809 - fix [#832](https://togithub.com/FakerPHP/Faker/issues/832) by [@gam6itko](https://togithub.com/gam6itko) in [FakerPHP/Faker#836 - Fix: Do not use deprecated `MT_RAND_PHP` constant on PHP 8.3 by [@localheinz](https://togithub.com/localheinz) in [FakerPHP/Faker#844 - Enhancement: Prepare release for `1.23.1` by [@localheinz](https://togithub.com/localheinz) in [FakerPHP/Faker#788 - Fix: Remove branch alias for `1.23` by [@localheinz](https://togithub.com/localheinz) in [FakerPHP/Faker#843 #### New Contributors - [@ivastly](https://togithub.com/ivastly) made their first contribution in [FakerPHP/Faker#660 - [@edgarsn](https://togithub.com/edgarsn) made their first contribution in [FakerPHP/Faker#661 - [@vintagesucks](https://togithub.com/vintagesucks) made their first contribution in [FakerPHP/Faker#670 - [@tomaszklim](https://togithub.com/tomaszklim) made their first contribution in [FakerPHP/Faker#664 - [@VincentLanglet](https://togithub.com/VincentLanglet) made their first contribution in [FakerPHP/Faker#674 - [@Chris53897](https://togithub.com/Chris53897) made their first contribution in [FakerPHP/Faker#684 - [@BoGnY](https://togithub.com/BoGnY) made their first contribution in [FakerPHP/Faker#802 - [@supgeek-rod](https://togithub.com/supgeek-rod) made their first contribution in [FakerPHP/Faker#809 - [@gam6itko](https://togithub.com/gam6itko) made their first contribution in [FakerPHP/Faker#836 **Full Changelog**: FakerPHP/Faker@v1.23.0...v1.23.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/RadioRoster/backend).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

localheinz added the bug Something isn't working label Sep 25, 2023

localheinz self-assigned this Sep 25, 2023

localheinz force-pushed the fix/static branch from 8e5702b to 6ca019d Compare September 25, 2023 16:38

Fix: Add tests

a6a0f53

localheinz force-pushed the fix/static branch from 6ca019d to a6a0f53 Compare September 25, 2023 16:46

Fix: Do not use static in callables

85fb5b3

localheinz marked this pull request as ready for review September 25, 2023 16:47

localheinz commented Sep 25, 2023

View reviewed changes

localheinz requested review from pimjansen and bram-pkg September 25, 2023 17:41

localheinz removed their assignment Sep 25, 2023

bram-pkg approved these changes Sep 26, 2023

View reviewed changes

bram-pkg merged commit 8d32135 into FakerPHP:1.23 Sep 26, 2023
12 checks passed

localheinz deleted the fix/static branch September 26, 2023 11:28

localheinz assigned bram-pkg Sep 26, 2023

localheinz mentioned this pull request Sep 26, 2023

Enhancement: Merge 1.23 into 2.0 #786

Merged

5 tasks

bram-pkg pushed a commit that referenced this pull request Sep 26, 2023

Fix: Do not use static in callables (#785) (#786)

5269675

* Fix: Add tests * Fix: Do not use static in callables

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Do not use `static` in callables #785

Fix: Do not use `static` in callables #785

localheinz commented Sep 25, 2023 •

edited

localheinz Sep 25, 2023

bram-pkg left a comment

localheinz commented Sep 26, 2023

		self::assertIsString($phoneNumber);
		self::assertNotEmpty($phoneNumber);

Fix: Do not use static in callables #785

Fix: Do not use static in callables #785

Conversation

localheinz commented Sep 25, 2023 • edited

What is the reason for this PR?

Author's checklist

Summary of changes

Review checklist

localheinz Sep 25, 2023

Choose a reason for hiding this comment

bram-pkg left a comment

Choose a reason for hiding this comment

localheinz commented Sep 26, 2023

Fix: Do not use `static` in callables #785

Fix: Do not use `static` in callables #785

localheinz commented Sep 25, 2023 •

edited