Fix bc check

.github/workflows/bc-check.yaml

@@ -17,4 +17,8 @@ jobs:
         uses: "actions/checkout@v3"
 
       - name: "Roave BC Check"
-        uses: "docker://nyholm/roave-bc-check-ga"
+        uses: "addnab/docker-run-action@v3"
+        with:
+          image: "nyholm/roave-bc-check-ga"
+          options: "--env GITHUB_REPOSITORY=${{ github.repository }} --user 1001 --volume ${{ github.workspace }}:/app"
+          run: "/entrypoint.sh"

.php-cs-fixer.dist.php

@@ -206,6 +206,6 @@
                 'property',
             ],
         ],
-        'void_return' => true,
+        'void_return' => false,
         'whitespace_after_comma_in_array' => true,
     ]);

src/Faker/Generator.php

@@ -597,7 +597,7 @@ public function ext(string $id): Extension\Extension
         return $extension;
     }
 
-    public function addProvider($provider): void
+    public function addProvider($provider)
     {
         array_unshift($this->providers, $provider);
 
@@ -682,7 +682,7 @@ public function valid(?\Closure $validator = null, int $maxRetries = 10000)
         return new ValidGenerator($this, $validator, $maxRetries);
     }
 
-    public function seed($seed = null): void
+    public function seed($seed = null)
     {
         if ($seed === null) {
             mt_srand();
@@ -966,7 +966,7 @@ public function __destruct()
         $this->seed();
     }
 
-    public function __wakeup(): void
+    public function __wakeup()
     {
         $this->formatters = [];
     }

src/Faker/ORM/CakePHP/EntityPopulator.php

@@ -27,17 +27,17 @@ public function __get($name)
     /**
      * @param string $name
      */
-    public function __set($name, $value): void
+    public function __set($name, $value)
     {
         $this->{$name} = $value;
     }
 
-    public function mergeColumnFormattersWith($columnFormatters): void
+    public function mergeColumnFormattersWith($columnFormatters)
     {
         $this->columnFormatters = array_merge($this->columnFormatters, $columnFormatters);
     }
 
-    public function mergeModifiersWith($modifiers): void
+    public function mergeModifiersWith($modifiers)
     {
         $this->modifiers = array_merge($this->modifiers, $modifiers);
     }
@@ -155,7 +155,7 @@ public function execute($class, $insertedEntities, $options = [])
         return $entity->{$pk[0]};
     }
 
-    public function setConnection($name): void
+    public function setConnection($name)
     {
         $this->connectionName = $name;
     }

src/Faker/ORM/Doctrine/EntityPopulator.php

@@ -38,7 +38,7 @@ public function getClass()
         return $this->class->getName();
     }
 
-    public function setColumnFormatters($columnFormatters): void
+    public function setColumnFormatters($columnFormatters)
     {
         $this->columnFormatters = $columnFormatters;
     }
@@ -51,12 +51,12 @@ public function getColumnFormatters()
         return $this->columnFormatters;
     }
 
-    public function mergeColumnFormattersWith($columnFormatters): void
+    public function mergeColumnFormattersWith($columnFormatters)
     {
         $this->columnFormatters = array_merge($this->columnFormatters, $columnFormatters);
     }
 
-    public function setModifiers(array $modifiers): void
+    public function setModifiers(array $modifiers)
     {
         $this->modifiers = $modifiers;
     }
@@ -69,7 +69,7 @@ public function getModifiers()
         return $this->modifiers;
     }
 
-    public function mergeModifiersWith(array $modifiers): void
+    public function mergeModifiersWith(array $modifiers)
     {
         $this->modifiers = array_merge($this->modifiers, $modifiers);
     }

src/Faker/ORM/Doctrine/Populator.php

@@ -61,7 +61,7 @@ public function __construct(Generator $generator, ObjectManager $manager = null,
      * @param mixed $entity A Doctrine classname, or a \Faker\ORM\Doctrine\EntityPopulator instance
      * @param int   $number The number of entities to populate
      */
-    public function addEntity($entity, $number, $customColumnFormatters = [], $customModifiers = [], $generateId = false): void
+    public function addEntity($entity, $number, $customColumnFormatters = [], $customModifiers = [], $generateId = false)
     {
         if (!$entity instanceof \Faker\ORM\Doctrine\EntityPopulator) {
             if (null === $this->manager) {

src/Faker/ORM/Mandango/EntityPopulator.php

@@ -29,7 +29,7 @@ public function getClass()
         return $this->class;
     }
 
-    public function setColumnFormatters($columnFormatters): void
+    public function setColumnFormatters($columnFormatters)
     {
         $this->columnFormatters = $columnFormatters;
     }
@@ -42,7 +42,7 @@ public function getColumnFormatters()
         return $this->columnFormatters;
     }
 
-    public function mergeColumnFormattersWith($columnFormatters): void
+    public function mergeColumnFormattersWith($columnFormatters)
     {
         $this->columnFormatters = array_merge($this->columnFormatters, $columnFormatters);
     }

src/Faker/ORM/Mandango/Populator.php

@@ -27,7 +27,7 @@ public function __construct(\Faker\Generator $generator, Mandango $mandango)
      * @param mixed $entity A Propel ActiveRecord classname, or a \Faker\ORM\Propel\EntityPopulator instance
      * @param int   $number The number of entities to populate
      */
-    public function addEntity($entity, $number, $customColumnFormatters = []): void
+    public function addEntity($entity, $number, $customColumnFormatters = [])
     {
         if (!$entity instanceof \Faker\ORM\Mandango\EntityPopulator) {
             $entity = new \Faker\ORM\Mandango\EntityPopulator($entity);

src/Faker/ORM/Propel/EntityPopulator.php

@@ -29,7 +29,7 @@ public function getClass()
         return $this->class;
     }
 
-    public function setColumnFormatters($columnFormatters): void
+    public function setColumnFormatters($columnFormatters)
     {
         $this->columnFormatters = $columnFormatters;
     }
@@ -42,7 +42,7 @@ public function getColumnFormatters()
         return $this->columnFormatters;
     }
 
-    public function mergeColumnFormattersWith($columnFormatters): void
+    public function mergeColumnFormattersWith($columnFormatters)
     {
         $this->columnFormatters = array_merge($this->columnFormatters, $columnFormatters);
     }
@@ -126,7 +126,7 @@ protected function isColumnBehavior(\ColumnMap $columnMap)
         return false;
     }
 
-    public function setModifiers($modifiers): void
+    public function setModifiers($modifiers)
     {
         $this->modifiers = $modifiers;
     }
@@ -139,7 +139,7 @@ public function getModifiers()
         return $this->modifiers;
     }
 
-    public function mergeModifiersWith($modifiers): void
+    public function mergeModifiersWith($modifiers)
     {
         $this->modifiers = array_merge($this->modifiers, $modifiers);
     }

src/Faker/ORM/Propel/Populator.php

@@ -23,7 +23,7 @@ public function __construct(\Faker\Generator $generator)
      * @param mixed $entity A Propel ActiveRecord classname, or a \Faker\ORM\Propel\EntityPopulator instance
      * @param int   $number The number of entities to populate
      */
-    public function addEntity($entity, $number, $customColumnFormatters = [], $customModifiers = []): void
+    public function addEntity($entity, $number, $customColumnFormatters = [], $customModifiers = [])
     {
         if (!$entity instanceof \Faker\ORM\Propel\EntityPopulator) {
             $entity = new \Faker\ORM\Propel\EntityPopulator($entity);

src/Faker/ORM/Propel2/EntityPopulator.php

@@ -30,7 +30,7 @@ public function getClass()
         return $this->class;
     }
 
-    public function setColumnFormatters($columnFormatters): void
+    public function setColumnFormatters($columnFormatters)
     {
         $this->columnFormatters = $columnFormatters;
     }
@@ -43,7 +43,7 @@ public function getColumnFormatters()
         return $this->columnFormatters;
     }
 
-    public function mergeColumnFormattersWith($columnFormatters): void
+    public function mergeColumnFormattersWith($columnFormatters)
     {
         $this->columnFormatters = array_merge($this->columnFormatters, $columnFormatters);
     }
@@ -129,7 +129,7 @@ protected function isColumnBehavior(ColumnMap $columnMap)
         return false;
     }
 
-    public function setModifiers($modifiers): void
+    public function setModifiers($modifiers)
     {
         $this->modifiers = $modifiers;
     }
@@ -142,7 +142,7 @@ public function getModifiers()
         return $this->modifiers;
     }
 
-    public function mergeModifiersWith($modifiers): void
+    public function mergeModifiersWith($modifiers)
     {
         $this->modifiers = array_merge($this->modifiers, $modifiers);
     }

src/Faker/ORM/Propel2/Populator.php

@@ -26,7 +26,7 @@ public function __construct(\Faker\Generator $generator)
      * @param mixed $entity A Propel ActiveRecord classname, or a \Faker\ORM\Propel2\EntityPopulator instance
      * @param int   $number The number of entities to populate
      */
-    public function addEntity($entity, $number, $customColumnFormatters = [], $customModifiers = []): void
+    public function addEntity($entity, $number, $customColumnFormatters = [], $customModifiers = [])
     {
         if (!$entity instanceof \Faker\ORM\Propel2\EntityPopulator) {
             $entity = new \Faker\ORM\Propel2\EntityPopulator($entity);

src/Faker/ORM/Spot/EntityPopulator.php

@@ -60,7 +60,7 @@ public function getMapper()
         return $this->mapper;
     }
 
-    public function setColumnFormatters($columnFormatters): void
+    public function setColumnFormatters($columnFormatters)
     {
         $this->columnFormatters = $columnFormatters;
     }
@@ -73,12 +73,12 @@ public function getColumnFormatters()
         return $this->columnFormatters;
     }
 
-    public function mergeColumnFormattersWith($columnFormatters): void
+    public function mergeColumnFormattersWith($columnFormatters)
     {
         $this->columnFormatters = array_merge($this->columnFormatters, $columnFormatters);
     }
 
-    public function setModifiers(array $modifiers): void
+    public function setModifiers(array $modifiers)
     {
         $this->modifiers = $modifiers;
     }
@@ -91,7 +91,7 @@ public function getModifiers()
         return $this->modifiers;
     }
 
-    public function mergeModifiersWith(array $modifiers): void
+    public function mergeModifiersWith(array $modifiers)
     {
         $this->modifiers = array_merge($this->modifiers, $modifiers);
     }

src/Faker/ORM/Spot/Populator.php

@@ -38,7 +38,7 @@ public function addEntity(
         $customColumnFormatters = [],
         $customModifiers = [],
         $useExistingData = false
-    ): void {
+    ) {
         $mapper = $this->locator->mapper($entityName);
 
         if (null === $mapper) {

src/Faker/Provider/DateTime.php

@@ -356,7 +356,7 @@ private static function setTimezone(\DateTime $dt, $timezone)
      *
      * @param string $timezone
      */
-    public static function setDefaultTimezone($timezone = null): void
+    public static function setDefaultTimezone($timezone = null)
     {
         static::$defaultTimezone = $timezone;
     }