Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bc check #572

Merged
merged 5 commits into from Dec 13, 2022
Merged

Fix bc check #572

merged 5 commits into from Dec 13, 2022

Conversation

MyIgel
Copy link

@MyIgel MyIgel commented Dec 10, 2022

What is the reason for this PR?

The bc check is currently not working.

Author's checklist

Summary of changes

At the moment the code gets checked out by a user with the uid 1001 but the nyholm/roave-bc-check-ga runs as root which triggers the fatal: detected dubious ownership in repository at '/github/workspace' error.
Running the commands in that container as a user with the user id 1001 is, to my understanding, not possible using default GitHub Actions config so the workaround of using addnab/docker-run-action@v3 is used to allow for defining the user id uding -u 1001 (and setting then not available, GITHUB_REPOSITORY variable).

Review checklist

  • All checks have passed
  • Changes are approved by maintainer

@MyIgel
Copy link
Author

MyIgel commented Dec 11, 2022

I can't say If that resut is whats expected but it seems to work ^^

@localheinz localheinz self-requested a review December 13, 2022 09:14
@localheinz localheinz self-assigned this Dec 13, 2022
@localheinz localheinz added the bug Something isn't working label Dec 13, 2022
@localheinz
Copy link
Member

@MyIgel

Nice, I will fix the issues related to #554!

Copy link
Member

@localheinz localheinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@localheinz localheinz merged commit 7ae22eb into FakerPHP:main Dec 13, 2022
@localheinz
Copy link
Member

Thank you, @MyIgel!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants