feat: allow forward slash in feed name #441
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sakshi1215 <sakshi.patle121@gmail.com>
|
@jennydaman I didn't hear from Kibablu in the previous PR where according to me the fix was not correctly implemented. Can you please review this? |
|
@sakshi1215 this is a good start. I don't think a unit test is sufficient to cover this change. Chances are that the slash restriction was originally put there for a good reason, so you'd have to write an integration test to ensure that there are no regressions introduced by the change. |
|
@sakshi1215 sorry, I worked on the issue before it was communicated to us to comment first |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: sakshi1215 sakshi.patle121@gmail.com
fixes #434