Bump min setuptools version and remove setup.py
#154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dham
added a commit
to firedrakeproject/ufl
that referenced
this pull request
May 5, 2023
This reverts commit 6eeef93.
dham
added a commit
to firedrakeproject/ufl
that referenced
this pull request
May 5, 2023
This reverts commit 6eeef93. Numpy currently pins setuptools to 59.2 see: numpy/numpy#22623 This commit caused UFL to require a lated setuptools. For complex reasons to do with blas dependencies, Firedrake builds numpy without build isolation. We also install UFL in editable mode, so that can't use build isolation. Consequently we are stuck on the pinned setuptools.
dham
added a commit
to firedrakeproject/ufl
that referenced
this pull request
May 5, 2023
This reverts commit 6eeef93. Numpy currently pins setuptools to 59.2 see: numpy/numpy#22623 This commit caused UFL to require a lated setuptools. For complex reasons to do with blas dependencies, Firedrake builds numpy without build isolation. We also install UFL in editable mode, so that can't use build isolation. Consequently we are stuck on the pinned setuptools.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplification possible following
setuptoolsfix. (pypa/setuptools#3151).