Fix endless Stream's reply waiting on vpp disconnect #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Draining of underlaying channel makes waiting endless. Now stream uses timeout to prevent it. Signed-off-by: Rinat Baygildin <bayrinat@yandex-team.ru> Change-Id: I9a48bf06a2073cb3e6efbeb530c267bd40ec086b FDio#76
|
https://gerrit.fd.io/r/c/govpp/+/36185 - the first attempt to fix it. Receiving message from Stream is independent from the channel's receiving. |
|
Gentle ping @ondrej-fabry to verify it. |
|
@ondrej-fabry review, plz :) |
ondrej-fabry
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draining of underlaying channel makes waiting endless. Now stream uses timeout to prevent it.
Signed-off-by: Rinat Baygildin bayrinat@yandex-team.ru
Change-Id: I9a48bf06a2073cb3e6efbeb530c267bd40ec086b
#76