Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stream.recvReply function is stuck on vpp disconect. #76

Closed
bayrinat opened this issue Oct 21, 2022 · 2 comments
Closed

Stream.recvReply function is stuck on vpp disconect. #76

bayrinat opened this issue Oct 21, 2022 · 2 comments

Comments

@bayrinat
Copy link
Contributor

recvReply function doesn't use any timeout to prevent endless waiting on the select statement.

That's why function RecvMsg is blocked even on vpp reconnection.
bayrinat added a commit to bayrinat/govpp that referenced this issue Oct 21, 2022
@bayrinat
Fix endless Stream's reply waiting on vpp disconnect
b285427 
Draining of underlaying channel makes waiting endless.
Now stream uses timeout to prevent it.

Signed-off-by: Rinat Baygildin <bayrinat@yandex-team.ru>
Change-Id: I9a48bf06a2073cb3e6efbeb530c267bd40ec086b

FDio#76
@bayrinat bayrinat mentioned this issue Oct 21, 2022
Merged
@ondrej-fabry
Copy link
Member

@bayrinat Is this resolved with #77 ?

@bayrinat
Copy link
Contributor Author

bayrinat commented Nov 3, 2022 •
edited

Yep.

@bayrinat bayrinat closed this as completed Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bayrinat @ondrej-fabry