RN: Cleanup Existing ESLint Warnings

Summary: Sometime over the past few months (and with changes such as migrating to the `hermes-eslint` parser), a bunch of lint warnings crept into the codebase. This does a pass to clean them all up, ignore generated files, and refactor some code to be... better. There should be no observable behavior changes as a result of this. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D38646643 fbshipit-source-id: a7b55d1e4cd5700340cc5c21f928baf3ea1d5a58
Expensify · Aug 17, 2022 · 0d55ccf · 0d55ccf
1 parent 08642ea
commit 0d55ccf
Show file tree

Hide file tree

Showing 23 changed files with 45 additions and 32 deletions.
diff --git a/.eslintignore b/.eslintignore
@@ -3,6 +3,7 @@
 bots/node_modules
 docs/generatedComponentApiDocs.js
 flow/
+flow-typed/
 Libraries/Renderer/*
 Libraries/vendor/**/*
 node_modules/

diff --git a/IntegrationTests/AppEventsTest.js b/IntegrationTests/AppEventsTest.js
@@ -38,7 +38,6 @@ class AppEventsTest extends React.Component<{...}, State> {
     NativeAppEventEmitter.addListener('testEvent', this.receiveEvent);
     const event = {data: TEST_PAYLOAD, ts: Date.now()};
     TestModule.sendAppEvent('testEvent', event);
-    // eslint-disable-next-line react/no-did-mount-set-state
     this.setState({sent: event});
   }
 

diff --git a/Libraries/Animated/animations/SpringAnimation.js b/Libraries/Animated/animations/SpringAnimation.js
@@ -10,9 +10,10 @@
 
 'use strict';
 
-const AnimatedValue = require('../nodes/AnimatedValue');
-const AnimatedValueXY = require('../nodes/AnimatedValueXY');
-const AnimatedInterpolation = require('../nodes/AnimatedInterpolation');
+import type AnimatedValue from '../nodes/AnimatedValue';
+import type AnimatedValueXY from '../nodes/AnimatedValueXY';
+import type AnimatedInterpolation from '../nodes/AnimatedInterpolation';
+
 const Animation = require('./Animation');
 const SpringConfig = require('../SpringConfig');
 

diff --git a/Libraries/Animated/animations/TimingAnimation.js b/Libraries/Animated/animations/TimingAnimation.js
@@ -10,9 +10,10 @@
 
 'use strict';
 
-const AnimatedValue = require('../nodes/AnimatedValue');
-const AnimatedValueXY = require('../nodes/AnimatedValueXY');
-const AnimatedInterpolation = require('../nodes/AnimatedInterpolation');
+import type AnimatedValue from '../nodes/AnimatedValue';
+import type AnimatedValueXY from '../nodes/AnimatedValueXY';
+import type AnimatedInterpolation from '../nodes/AnimatedInterpolation';
+
 const Animation = require('./Animation');
 
 const {shouldUseNativeDriver} = require('../NativeAnimatedHelper');

diff --git a/Libraries/Animated/nodes/AnimatedAddition.js b/Libraries/Animated/nodes/AnimatedAddition.js
@@ -10,8 +10,9 @@
 
 'use strict';
 
+import type AnimatedNode from './AnimatedNode';
+
 const AnimatedInterpolation = require('./AnimatedInterpolation');
-const AnimatedNode = require('./AnimatedNode');
 const AnimatedValue = require('./AnimatedValue');
 const AnimatedWithChildren = require('./AnimatedWithChildren');
 

diff --git a/Libraries/Animated/nodes/AnimatedDiffClamp.js b/Libraries/Animated/nodes/AnimatedDiffClamp.js
@@ -10,8 +10,9 @@
 
 'use strict';
 
+import type AnimatedNode from './AnimatedNode';
+
 const AnimatedInterpolation = require('./AnimatedInterpolation');
-const AnimatedNode = require('./AnimatedNode');
 const AnimatedWithChildren = require('./AnimatedWithChildren');
 
 import type {InterpolationConfigType} from './AnimatedInterpolation';

diff --git a/Libraries/Animated/nodes/AnimatedInterpolation.js b/Libraries/Animated/nodes/AnimatedInterpolation.js
@@ -12,7 +12,8 @@
 
 'use strict';
 
-const AnimatedNode = require('./AnimatedNode');
+import type AnimatedNode from './AnimatedNode';
+
 const AnimatedWithChildren = require('./AnimatedWithChildren');
 const NativeAnimatedHelper = require('../NativeAnimatedHelper');
 

diff --git a/Libraries/Animated/nodes/AnimatedModulo.js b/Libraries/Animated/nodes/AnimatedModulo.js
@@ -10,8 +10,9 @@
 
 'use strict';
 
+import type AnimatedNode from './AnimatedNode';
+
 const AnimatedInterpolation = require('./AnimatedInterpolation');
-const AnimatedNode = require('./AnimatedNode');
 const AnimatedWithChildren = require('./AnimatedWithChildren');
 
 import type {InterpolationConfigType} from './AnimatedInterpolation';

diff --git a/Libraries/Animated/nodes/AnimatedMultiplication.js b/Libraries/Animated/nodes/AnimatedMultiplication.js
@@ -10,8 +10,9 @@
 
 'use strict';
 
+import type AnimatedNode from './AnimatedNode';
+
 const AnimatedInterpolation = require('./AnimatedInterpolation');
-const AnimatedNode = require('./AnimatedNode');
 const AnimatedValue = require('./AnimatedValue');
 const AnimatedWithChildren = require('./AnimatedWithChildren');
 

diff --git a/Libraries/Animated/nodes/AnimatedSubtraction.js b/Libraries/Animated/nodes/AnimatedSubtraction.js
@@ -10,8 +10,9 @@
 
 'use strict';
 
+import type AnimatedNode from './AnimatedNode';
+
 const AnimatedInterpolation = require('./AnimatedInterpolation');
-const AnimatedNode = require('./AnimatedNode');
 const AnimatedValue = require('./AnimatedValue');
 const AnimatedWithChildren = require('./AnimatedWithChildren');
 

diff --git a/Libraries/Animated/nodes/AnimatedTracking.js b/Libraries/Animated/nodes/AnimatedTracking.js
@@ -10,7 +10,8 @@
 
 'use strict';
 
-const AnimatedValue = require('./AnimatedValue');
+import type AnimatedValue from './AnimatedValue';
+
 const AnimatedNode = require('./AnimatedNode');
 const {
   generateNewAnimationId,

diff --git a/Libraries/BatchedBridge/MessageQueue.js b/Libraries/BatchedBridge/MessageQueue.js
@@ -380,7 +380,7 @@ class MessageQueue {
     return (
       // $FlowFixMe[cannot-resolve-name]
       typeof DebuggerInternal !== 'undefined' &&
-      DebuggerInternal.shouldPauseOnThrow === true // eslint-disable-line no-undef
+      DebuggerInternal.shouldPauseOnThrow === true
     );
   }
 

diff --git a/Libraries/Blob/FileReader.js b/Libraries/Blob/FileReader.js
@@ -8,7 +8,8 @@
  * @format
  */
 
-const Blob = require('./Blob');
+import type Blob from './Blob';
+
 const EventTarget = require('event-target-shim');
 
 import NativeFileReaderModule from './NativeFileReaderModule';

diff --git a/Libraries/Blob/URL.js b/Libraries/Blob/URL.js
@@ -8,7 +8,7 @@
  * @flow
  */
 
-const Blob = require('./Blob');
+import type Blob from './Blob';
 
 import NativeBlobModule from './NativeBlobModule';
 

diff --git a/Libraries/Events/EventPolyfill.js b/Libraries/Events/EventPolyfill.js
@@ -227,7 +227,7 @@ class EventPolyfill implements IEvent {
 }
 
 // Assertion magic for polyfill follows.
-declare var checkEvent: Event;
+declare var checkEvent: Event; // eslint-disable-line no-unused-vars
 
 /*::
 // This can be a strict mode error at runtime so put it in a Flow comment.

diff --git a/Libraries/JSInspector/JSInspector.js b/Libraries/JSInspector/JSInspector.js
@@ -19,9 +19,6 @@ interface Agent {
 // Flow doesn't support static declarations in interface
 type AgentClass = Class<Agent> & {DOMAIN: string, ...};
 
-declare function __registerInspectorAgent(type: AgentClass): void;
-declare function __inspectorTimestamp(): number;
-
 const JSInspector = {
   registerAgent(type: AgentClass) {
     if (global.__registerInspectorAgent) {

diff --git a/Libraries/LogBox/Data/parseLogBoxLog.js b/Libraries/LogBox/Data/parseLogBoxLog.js
@@ -17,6 +17,7 @@ import parseErrorStack from '../../Core/Devtools/parseErrorStack';
 const BABEL_TRANSFORM_ERROR_FORMAT =
   /^(?:TransformError )?(?:SyntaxError: |ReferenceError: )(.*): (.*) \((\d+):(\d+)\)\n\n([\s\S]+)/;
 const BABEL_CODE_FRAME_ERROR_FORMAT =
+  // eslint-disable-next-line no-control-regex
   /^(?:TransformError )?(?:.*):? (?:.*?)(\/.*): ([\s\S]+?)\n([ >]{2}[\d\s]+ \|[\s\S]+|\u{001b}[\s\S]+)/u;
 const METRO_ERROR_FORMAT =
   /^(?:InternalError Metro has encountered an error:) (.*): (.*) \((\d+):(\d+)\)\n\n([\s\S]+)/u;

diff --git a/Libraries/StyleSheet/StyleSheetTypes.js b/Libraries/StyleSheet/StyleSheetTypes.js
@@ -10,7 +10,7 @@
 
 'use strict';
 
-const AnimatedNode = require('../Animated/nodes/AnimatedNode');
+import type AnimatedNode from '../Animated/nodes/AnimatedNode';
 
 import type {NativeColorValue} from './PlatformColorValueTypes';
 

diff --git a/Libraries/StyleSheet/private/_TransformStyle.js b/Libraries/StyleSheet/private/_TransformStyle.js
@@ -8,7 +8,7 @@
  * @format
  */
 
-const AnimatedNode = require('../../Animated/nodes/AnimatedNode');
+import type AnimatedNode from '../../Animated/nodes/AnimatedNode';
 
 export type ____TransformStyle_Internal = $ReadOnly<{|
   /**

diff --git a/interface.js b/interface.js
@@ -10,6 +10,14 @@
 
 'use strict';
 
+// NOTE: Hmm... I don't think declaring variables within this module actually
+// accomplishes anything besides documenting that these globals are exepcted to
+// exist. So I think the correct "fix" to this lint warning is to delete this
+// entire file. But in lieu of doing that... no harm for now in keeping this
+// file around, even if it is only for documentation purposes. ¯\_(ツ)_/¯
+
+/* eslint-disable no-unused-vars */
+
 declare var __DEV__: boolean;
 
 declare var __REACT_DEVTOOLS_GLOBAL_HOOK__: any; /*?{

diff --git a/packages/react-native-codegen/src/generators/modules/GenerateModuleObjCpp/serializeMethod.js b/packages/react-native-codegen/src/generators/modules/GenerateModuleObjCpp/serializeMethod.js
@@ -19,9 +19,9 @@ import type {
 } from '../../../CodegenSchema';
 
 import type {AliasResolver} from '../Utils';
+import type {StructCollector} from './StructCollector';
 
 const invariant = require('invariant');
-const {StructCollector} = require('./StructCollector');
 const {getNamespacedStructName} = require('./Utils');
 const {capitalize} = require('../../Utils');
 const {

diff --git a/packages/react-native-codegen/src/parsers/flow/modules/__tests__/module-parser-e2e-test.js b/packages/react-native-codegen/src/parsers/flow/modules/__tests__/module-parser-e2e-test.js
@@ -816,8 +816,7 @@ describe('Flow Module Parser', () => {
             describe('Primitive Element Types', () => {
               PRIMITIVES.forEach(([FLOW_TYPE, PARSED_TYPE_NAME]) => {
                 it(`should parse methods that have ${RETURN_TYPE_DESCRIPTION} return of type 'Array<${FLOW_TYPE}>'`, () => {
-                  const [elementType, module] =
-                    parseArrayElementReturnType(FLOW_TYPE);
+                  const [elementType] = parseArrayElementReturnType(FLOW_TYPE);
                   expect(elementType.type).toBe(PARSED_TYPE_NAME);
                 });
               });

diff --git a/scripts/codegen/__tests__/generate-specs-cli-executor-test.js b/scripts/codegen/__tests__/generate-specs-cli-executor-test.js
@@ -12,20 +12,18 @@
 
 const sut = require('../generate-specs-cli-executor');
 const fixtures = require('../__test_fixtures__/fixtures');
-const path = require('path');
+const {normalize} = require('path');
 
 describe('generateSpec', () => {
   it('invokes RNCodegen with the right params', () => {
     const platform = 'ios';
     const libraryType = 'all';
     const schemaPath = './';
-    const componentsOutputDir = path.normalize(
+    const componentsOutputDir = normalize(
       'app/ios/build/generated/ios/react/renderer/components/library',
     );
-    const modulesOutputDir = path.normalize(
-      'app/ios/build/generated/ios/library',
-    );
-    const outputDirectory = path.normalize('app/ios/build/generated/ios');
+    const modulesOutputDir = normalize('app/ios/build/generated/ios/library');
+    const outputDirectory = normalize('app/ios/build/generated/ios');
     const libraryName = 'library';
     const packageName = 'com.library';
     const generators = ['componentsIOS', 'modulesIOS'];