Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Add jcenter back to build.gradle #7191

Merged
merged 1 commit into from
Jan 13, 2022
Merged

[No QA] Add jcenter back to build.gradle #7191

merged 1 commit into from
Jan 13, 2022

Conversation

roryabraham
Copy link
Contributor

@roryabraham roryabraham commented Jan 13, 2022

Details

This temporary fix should hopefully unblock Android deploys. More context in slack

Fixed Issues

$ n/a

Tests

Verify that the Android dev build runs. I've never succeeded in locally creating an Android production build, so I think it'll be easier to just merge this and see if it works.

QA Steps

None.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Android

image

@roryabraham roryabraham self-assigned this Jan 13, 2022
@roryabraham roryabraham marked this pull request as ready for review January 13, 2022 00:54
@roryabraham roryabraham requested a review from a team as a code owner January 13, 2022 00:54
@MelvinBot MelvinBot removed the request for review from a team January 13, 2022 00:55
@roryabraham
Copy link
Contributor Author

Requesting review from @Jag96 to unblock NewDot Android deploys.

@Jag96
Copy link
Contributor

Jag96 commented Jan 13, 2022

Discussed in slack, link to PR where this was originally removed: #6914 (comment).

@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@roryabraham
Copy link
Contributor Author

Since we don't have any Android E2E tests I would say no need to wait for the iOS E2E tests. We know that this gradle config is not going to affect iOS.

@roryabraham
Copy link
Contributor Author

Going to try this out and see if it works

@Jag96
Copy link
Contributor

Jag96 commented Jan 13, 2022

Skipping unnecessary E2E

@Jag96 Jag96 merged commit c1ceb3b into main Jan 13, 2022
@Jag96 Jag96 deleted the Rory-AddJCenterBack branch January 13, 2022 01:00
@botify
Copy link

botify commented Jan 13, 2022

@Jag96 looks like this was merged without passing tests. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@Jag96 Jag96 removed the Emergency label Jan 13, 2022
OSBotify pushed a commit that referenced this pull request Jan 13, 2022
[No QA] Add jcenter back to build.gradle

(cherry picked from commit c1ceb3b)
@roryabraham
Copy link
Contributor Author

Build running here

@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @Jag96 in version: 1.1.29-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @Jag96 in version: 1.1.29-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants