feat: dataloader instrumentations stop using deprecated methods #1493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariuszkuc
reviewed
Jul 28, 2022
...expediagroup/graphql/dataloader/instrumentation/level/state/ExecutionLevelDispatchedState.kt
Outdated
Show resolved
Hide resolved
dariuszkuc
reviewed
Jul 28, 2022
...group/graphql/dataloader/instrumentation/syncexhaustion/state/SyncExecutionExhaustedState.kt
Outdated
Show resolved
Hide resolved
dariuszkuc
approved these changes
Jul 28, 2022
dariuszkuc
pushed a commit
to dariuszkuc/graphql-kotlin
that referenced
this pull request
Aug 5, 2022
…diaGroup#1493) * feat: dataloader instrumentations stop using deprecated methods * feat: computeIfAbsent on instrumentations state Co-authored-by: samvazquez <samvazquez@expedia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
graphql-java 19 deprecated all
instrumentXXXin favor or methods receiving theinstrumentationState🔗 Related Issues
graphql-java/graphql-java#2769