chore: updates docs and example to use transports #49
Conversation
Uses thread-stream to create a single worker to forward data to all target destinations
…er plugins for the hapi plugin
Looks like updating the unit tests for index.test.js should have the tests running 💯 again. 🤝 Long Live Catalyst 🚀✨🌕 |
Thanks @mannyluvstacos! I will review the unit tests once my code is ready! I wanna use the manifest.json to register this code instead the index.js file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is not doing what the title says. It is only adding an example for how to use transports with pino-pretty in local development.
node js profile for pino-http-print no 1 node js profile for pino-http-print no 2 |
Pending review unit tests and pass the code to the manifest file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment. Also, when squashing and merging, we should update the commit message to be something like: chore: updates docs and example to use transports for pino-pretty
Co-authored-by: Bryan Shell <shellbj@users.noreply.github.com>
Co-authored-by: Bryan Shell <shellbj@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really want to advertise this approach? What is the advantage here? pino-rotating-file
is similarly in its own process plus it supports log rotation. Can/should we just show that in the Readme rather than create examples that we need to keep updated?
Not really.
It cleaned up some of the configuration in the example and docs to show how to move pretty into a conditional transport.
This and update the example/default to use a |
Yes! this pr will help our developers a quick and easy way to transport and transform logs for production... if necessary, the examples serve as a guide/introduction to make a more advanced configuration. |
Co-authored-by: Bryan Shell <shellbj@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just a reminder... when squashing and merging, please update the commit message to be something like: chore: updates docs and example to use transports
🎉 This PR is included in version 5.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Uses thread-stream to create a single worker to forward data to all target destinations