switch from custom stringFormat to fmtlib #2769
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2769 +/- ##
==========================================
- Coverage 64.62% 64.57% -0.05%
==========================================
Files 104 104
Lines 22239 22155 -84
Branches 10911 10849 -62
==========================================
- Hits 14371 14306 -65
+ Misses 5626 5610 -16
+ Partials 2242 2239 -3 ☔ View full report in Codecov by Sentry. |
|
How about we just wait for C++20 as min requirement and use std::format straight away? Or code it in a way to use std::format if using C++20 so there is one less dependency? |
neheb
force-pushed
the
fmt
branch
7 times, most recently
from
1ac41a6
to
db8dbda
Compare
neheb
force-pushed
the
fmt
branch
9 times, most recently
from
43e31a2
to
51b29fe
Compare
|
Sounds like the python in use is having its SSL module load some outdated ca-certificates that no longer work well. |
.github/workflows/on_PR_meson.yaml
Outdated
| packages: :> | ||
| ca-certificates | ||
| cmake | ||
| gcc-g++ |
There was a problem hiding this comment.
There was a problem hiding this comment.
meson.build:1:0: ERROR: Unknown compiler(s): [['g++-13']]
The following exception(s) were encountered:
Running `g++-13 --version` gave "[Errno 2] No such file or directory: 'g++-13'"
This is making me want to give up and just use MSYS2 instead.
There was a problem hiding this comment.
I'm impressed by your persistence so far 😉
Let's just comment out Cygwin and bring it back when gcc13 becomes current there.
There was a problem hiding this comment.
Not giving up yet :)
I tested compiling fmt on Cygwin. Didn't work. I'll use MSYS2 instead, which is Cygwin without old compilers/packages.
There was a problem hiding this comment.
Finally got this damn thing building. Some of the wraps are broken. I'll reintroduce that after I fix.
There was a problem hiding this comment.
Re Cygwin: still no insights when they might move away from GCC 11, and packaging fmt seems not to be a priority.
neheb
force-pushed
the
fmt
branch
18 times, most recently
from
e204e8b
to
2efbdf3
Compare
|
remaining error needs to be fixed by @kevinbackhouse I think. |
|
Rebased. |
The latter helps to avoid wrong format errors and is simpler to use. Will be replaced by std::format once C++20 becomes mandatory. Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Rosen Penev <rosenp@gmail.com>
The latter helps to avoid wrong format errors and is simpler to use. Will be replaced by std::format once C++20 becomes mandatory.