Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more NEF compression details #2055

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add more NEF compression details #2055

wants to merge 1 commit into from

Conversation

kmilos
Copy link
Collaborator

@kmilos kmilos commented Jan 14, 2022

Found in newer Z bodies, as reported by exiftool

@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #2055 (8dddc6e) into main (55712d4) will decrease coverage by 55.76%.
The diff coverage is n/a.

❗ Current head 8dddc6e differs from pull request most recent head 7804e10. Consider uploading reports for the commit 7804e10 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main   #2055       +/-   ##
==========================================
- Coverage   61.48%   5.72%   -55.77%     
==========================================
  Files          96      96               
  Lines       19207   18955      -252     
  Branches     9843    9843               
==========================================
- Hits        11810    1085    -10725     
- Misses       5080   17682    +12602     
+ Partials     2317     188     -2129     
Impacted Files Coverage Δ
src/nikonmn_int.cpp 0.00% <ø> (-46.77%) ⬇️
src/getopt.hpp 0.00% <0.00%> (-100.00%) ⬇️
src/actions.hpp 0.00% <0.00%> (-100.00%) ⬇️
src/exiv2app.hpp 0.00% <0.00%> (-100.00%) ⬇️
src/fujimn_int.cpp 0.00% <0.00%> (-100.00%) ⬇️
src/orfimage_int.hpp 0.00% <0.00%> (-100.00%) ⬇️
src/rw2image_int.hpp 0.00% <0.00%> (-100.00%) ⬇️
include/exiv2/exif.hpp 0.00% <0.00%> (-100.00%) ⬇️
include/exiv2/iptc.hpp 0.00% <0.00%> (-100.00%) ⬇️
include/exiv2/tags.hpp 0.00% <0.00%> (-100.00%) ⬇️
... and 80 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55712d4...7804e10. Read the comment docs.

@kmilos kmilos marked this pull request as draft January 14, 2022 13:06
@piponazo
Copy link
Collaborator

Looks fine to me. I would only add a comment indicating where the reader can find more information about those different options.

Actually In this page from exiftool I see some values that are not added here (5, 7, 8):
https://exiftool.org/TagNames/Nikon.html#NEFCompression

Why are you not adding those ones?

@kmilos
Copy link
Collaborator Author

kmilos commented Jan 27, 2022

Thanks for taking a look. Actually we got stuck at synchronizing the labels in exiftool/exiftool#117

@neheb
Copy link
Collaborator

neheb commented Feb 24, 2023

Needs a rebase

@kmilos
Copy link
Collaborator Author

kmilos commented Feb 24, 2023

Actually, there is an unknown data struct behind a new MakerNote tag we don't support yet where these new values (13 & 14) come into play, hence the draft status... And there has been no conclusion of exiftool/exiftool#117 either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants