Lock conan version on Windows. #1897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 0.27-maintenance #1897 +/- ##
=================================================
Coverage 46.30% 46.30%
=================================================
Files 146 146
Lines 22948 22948
Branches 11781 11781
=================================================
Hits 10626 10626
Misses 6707 6707
Partials 5615 5615 Continue to review full report at Codecov.
|
kevinbackhouse
force-pushed
the
DowngradeConan
branch
from
3fa138a
to
6c6c32e
Compare
kevinbackhouse
added
the
forward-to-main
clanmills
reviewed
Sep 9, 2021
There was a problem hiding this comment.
Great Work, @kevinbackhouse
If you ever want a reference (for a job or any other purpose), it would be my pleasure to recommend you to anybody.
I'm approving this now and you can merge when the CI is green.
clanmills
approved these changes
Sep 9, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent release of Conan version 1.40 broke our Windows builds. I believe this change is responsible. As a short term fix, I think the best solution is to use Conan version 1.39.0. It turns out we were already locking the conan version to 1.36.0 on every platform except Windows, which is why the build only broke on Windows. This PR locks the version to 1.39.0 on all platforms.