Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Cache-Control rule #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

JasoonS
Copy link

@JasoonS JasoonS commented Aug 11, 2018

This is needed for proxies that interfere with the request (by doing things such as caching). This was the case with the create-react-app, when proxying requests to the dev-server backend to your real backend. See this issue: facebook/create-react-app#1633 (comment) . Maybe this header isn't always desired, but I didn't know a good way to make this configurable other than passing a 3rd argument to this pipe function, or maybe an extra parameter to the constructor allowing users to overwrite some of these headers if they want.

This is needed for proxies that interfere with the request (such as caching). This was the case with the `create-react-app`, when proxying requests to the dev-server backend to your real backend. See this issue: facebook/create-react-app#1633 (comment) . Maybe this header isn't always desired, but I didn't know a good way to make this configurable other than passing a 3rd argument to this `pipe` function, or maybe an extra parameter to the constructor allowing users to overwrite some of these headers if they want.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant