Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass withCredentials on to the XHR #79

Merged
merged 2 commits into from Jun 19, 2017

Commits on Jun 19, 2017

  1. Pass withCredentials on to the XHR

    - See https://www.w3.org/TR/eventsource/#dom-eventsource-withcredentials
    - I noticed during application testing that `{withCredentials: true}` was
      not including the session cookie, in fact, setting the flag in the polyfill
      had no effect at all. After a little digging, I learned that simply passing
      the option to the `http` object was that was needed.
    - I tried writing a test to confirm this, but could not figure out a way to
      do it (the only difference in real life is that the `Cookie` header is set
      if there's a cookie in the `document`
    kmayer authored and Ken Mayer committed Jun 19, 2017
    Copy the full SHA
    270fefc View commit details
    Browse the repository at this point in the history
  2. Re-build polyfill

    Ken Mayer committed Jun 19, 2017
    Copy the full SHA
    ef778b1 View commit details
    Browse the repository at this point in the history