Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue: reconnection only happends for 1 time after connection drops #136

Merged
merged 1 commit into from Jul 7, 2020
Merged

Fix issue: reconnection only happends for 1 time after connection drops #136

merged 1 commit into from Jul 7, 2020
+29 −0

Commits on May 24, 2020

  1. Fix issue: reconnection only happends for 1 time after connection drops 

    Since the PR EventSource#125 fixed duplicate connections after reconnection by using a `connectionInProgress` lock to avoid function `connect()` be called duplicately.

But it forgot to release the `connectionInProgress` lock when request error happends, in that case, our client can only retry for 1 time and never get the lock again.

So it's needed to release the `connectionInProgress` lock when error happends.

Signed-off-by: icy_fish <keith519@qq.com>
    @icy-fish
    icy-fish committed May 24, 2020
    Copy the full SHA
    9a4190f View commit details
    Browse the repository at this point in the history