Merge pull request #323 from evanshortiss/master

fix: empty options no longer disable certificate checks
EventSource · Aug 9, 2023 · db562b8 · db562b8
2 parents 79dacfa + 372d387
commit db562b8
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/lib/eventsource.js b/lib/eventsource.js
@@ -103,7 +103,7 @@ function EventSource (url, eventSourceInitDict) {
 
     // Legacy: this should be specified as `eventSourceInitDict.https.rejectUnauthorized`,
     // but for now exists as a backwards-compatibility layer
-    options.rejectUnauthorized = !(eventSourceInitDict && !eventSourceInitDict.rejectUnauthorized)
+    options.rejectUnauthorized = !(eventSourceInitDict && typeof eventSourceInitDict.rejectUnauthorized === 'boolean' && !eventSourceInitDict.rejectUnauthorized)
 
     if (eventSourceInitDict && eventSourceInitDict.createConnection !== undefined) {
       options.createConnection = eventSourceInitDict.createConnection

diff --git a/test/eventsource_test.js b/test/eventsource_test.js
@@ -705,6 +705,20 @@ describe('HTTPS Support', function () {
       }
     })
   })
+
+  it('fails to connect to self signed servers when options are provided but options.rejectUnauthorized is not specified', function (done) {
+    createHttpsServer(function (err, server) {
+      if (err) return done(err)
+
+      var es = new EventSource(server.url, {})
+      es.onopen = function () {
+        done(new Error('the socket should not have been opened, since options.rejectUnauthorized was not set to true'))
+      }
+      es.onerror = function () {
+        done()
+      }
+    })
+  })
 })
 
 describe('HTTPS Client Certificate Support', function () {