use winSCP.com utility to convert private key to ppk to launch winSCP #7398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drop node-forge dependency
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7204
Using winSCP.com utility that comes with winSCP to convert private key to ppk for winSCP connection for it's support of many different types of key types(RSA, DSA, ECDSA, Ed25519).
As an additional improvement it could show error message in case something goes wrong in a popup/modal rather than just in the console, but I didn't make that more involved change.
Tested with rsa, ecdsa and ed25519 keys in different formats, both password protected and passwordless(sshpk takes care of unencrypting the key beforehand).
Drop node-forge dependency as redundant.