Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disregard stale DynamicMapLayer updates #1261

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

davetapley
Copy link

Alleviates #749 by not updating layer with image for a set of params which have changed while request was in flight.

This isn't the most elegant solution; I'm very open to feedback 😁

Alleviates (1) by not updating layer
with image for a set of params which have changed
while request was in flight.

(1) Esri#749
@jwasilgeo
Copy link
Contributor

Hi @davetapley, thank you for offering this change, we appreciate it! 👍

As a holistic, longer-term update, I'd like to see esri-leaflet's requests mechanisms be updated to support network requests that can be aborted/canceled, as folks have mentioned in #749. It is on our radar to evaluate and consider that more closely, as it would be a bit of an update that would likely lead to a major version release.

I think for now we'll leave your proposed change parked here while we figure out next steps.

@AStasyK
Copy link

AStasyK commented Aug 10, 2023

Hello @jwasilgeo, We're having the same issue in our application. I hope the solution is progressing. It will be very important!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants