Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use rollup-plugin-terser instead of rollup-plugin-uglify #1235

Closed
wants to merge 1 commit into from

Conversation

gavinr
Copy link
Contributor

@gavinr gavinr commented Oct 5, 2020

Right now there's a security issue:

High            Remote Code Execution
  Package         serialize-javascript
  Patched in      >=3.1.0
  Dependency of   rollup-plugin-uglify [dev]
  Path            rollup-plugin-uglify > serialize-javascript
  More info       https://npmjs.com/advisories/1548
found 1 high severity vulnerability in 832 scanned packages

It seems like this plugin might not be supported anymore, (TrySound/rollup-plugin-uglify#87) so switching this to an alternate. It seems like the copyright note is not on the output esri-leaflet.js file though - may need to look into this.

instead of rollup-plugin-uglify
@jwasilgeo
Copy link
Contributor

If this change goes through, then I suggest we also think about updating these plugins' npm deps that rely on esri-leaflet's own Rollup config:

This plugin does its own Rollup config, but we should see if anything needs to be done:

Am I missing anything?

@gavinr gavinr self-assigned this Dec 28, 2020
@gavinr
Copy link
Contributor Author

gavinr commented Feb 14, 2022

Closing in favor of #1315

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants