Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert-pr-1011 #1223

Merged
merged 1 commit into from
Jul 28, 2020
Merged

revert-pr-1011 #1223

merged 1 commit into from
Jul 28, 2020

Conversation

jwasilgeo
Copy link
Contributor

reverting changes introduced in pr #1011

resolves #1210

see enhancement issue #1222 for revisiting bringing this back in down the road

@gavinr
Copy link
Contributor

gavinr commented Jul 28, 2020

The code changes look great, but ....

I noticed that after these changes, if you zoom into the Atlantic ocean, you get gray "map data not yet available" errors starting at zoom level 14: http://somup.com/cYiuD262nw .. I thought we were expecting that if we reverted this and set the maxZoom to 19, then we would at least have tiles everywhere on the world.

Copy link
Contributor

@jgravois jgravois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you zoom into the Atlantic ocean, you get gray "map data not yet available" errors starting at zoom level 14

that is true of the Topographic basemap and others as well. They don't cook tiles to level 19 in the middle of the ocean.

https://esri.github.io/esri-leaflet/examples/switching-basemaps.html

@gavinr
Copy link
Contributor

gavinr commented Jul 28, 2020

Huh, I never noticed that. Given that it's now consistent with the other basemaps, sounds good to me to merge this.

@jwasilgeo jwasilgeo merged commit 8e78cfa into master Jul 28, 2020
@jwasilgeo jwasilgeo deleted the revert-pr-1011 branch July 28, 2020 17:41
jgravois pushed a commit to jgravois/esri-leaflet that referenced this pull request Apr 23, 2022
jgravois pushed a commit to jgravois/esri-leaflet that referenced this pull request Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The maxNativeZoom option of the layer is not being set when using L.esri.basemapLayer
3 participants