Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(block): update text hierarchy and spacing #9329

Merged
merged 1 commit into from
May 14, 2024

Conversation

Elijbet
Copy link
Contributor

@Elijbet Elijbet commented May 14, 2024

Related Issue: #9323

Summary

Update block's padding.

@Elijbet Elijbet requested a review from a team as a code owner May 14, 2024 01:36
@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label May 14, 2024
@Elijbet Elijbet added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label May 14, 2024
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Before merging, can you update the conventional commit's description/message from the PR title to use the imperative, present tense per the conventions we link to in our contributing doc?

@jcfranco
Copy link
Member

@Elijbet Can you also add the visual changes label to the linked issue?

@Elijbet Elijbet changed the title fix(block): text hierarchy and spacing fix(block): update text hierarchy and spacing May 14, 2024
@Elijbet Elijbet merged commit 796372e into main May 14, 2024
12 checks passed
@Elijbet Elijbet deleted the elijbet/9323-block-text-hierarchy-and-spacing branch May 14, 2024 20:07
benelan added a commit that referenced this pull request May 14, 2024
…otfix-ci

* origin/main:
  fix(block): update text hierarchy and spacing (#9329)
benelan added a commit that referenced this pull request May 14, 2024
…fix-release

* origin/main:
  ci: setup hotfix releasing scripts and settings (#9337)
  fix(carousel): animate items with the same direction (#9335)
  chore: release next
  build(deps): update dependency @esri/calcite-ui-icons to v3.28.1 (#9336)
  fix: add type-fest as dependency due to build error (#9334)
  chore: release next
  fix(block): update text hierarchy and spacing (#9329)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants