-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(carousel): animate items with the same direction #9325
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome !
@@ -653,3 +653,61 @@ export function isBefore(a: HTMLElement, b: HTMLElement): boolean { | |||
const children = Array.from(a.parentNode.children); | |||
return children.indexOf(a) < children.indexOf(b); | |||
} | |||
|
|||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎈
E2E test added! |
🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-components: 2.8.1</summary> ## [2.8.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.8.0...@esri/calcite-components@2.8.1) (2024-05-14) ### Bug Fixes * Add type-fest as dependency due to build error ([3819688](3819688)) * **carousel:** Animate items with the same direction ([#9325](#9325)) ([6bf7b74](6bf7b74)) * **input, input-number, input-text:** Restore `autofocus`, `enter-key-mode` and `input-mode` attributes ([#9245](#9245)) ([#9306](#9306)) ([0498c6e](0498c6e)) * **list-item:** Decrease horizontal spacing between selection icon and content ([#9304](#9304)) ([0e828b6](0e828b6)) </details> <details><summary>@esri/calcite-components-angular: 2.8.1</summary> ## [2.8.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.8.0...@esri/calcite-components-angular@2.8.1) (2024-05-14) ### Miscellaneous Chores * **@esri/calcite-components-angular:** Synchronize components versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.8.1-hotfix.0 to ^2.8.1 </details> <details><summary>@esri/calcite-components-react: 2.8.1</summary> ## [2.8.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.8.0...@esri/calcite-components-react@2.8.1) (2024-05-14) ### Miscellaneous Chores * **@esri/calcite-components-react:** Synchronize components versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.8.1-hotfix.0 to ^2.8.1 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
**Related Issue:** #9232 ## Summary Updates carousel to wait for item animations before each slide. **Note**: I'll submit a follow-up PR to refactor [`openCloseComponent.onToggleOpenCloseComponent`](https://github.com/Esri/calcite-design-system/blob/main/packages/calcite-components/src/utils/openCloseComponent.ts#L91) to use the same DOM util as carousel.
🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-components: 2.8.1</summary> [2.8.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.8.0...@esri/calcite-components@2.8.1) (2024-05-14) * Add type-fest as dependency due to build error ([3819688](3819688)) * **carousel:** Animate items with the same direction ([#9325](#9325)) ([6bf7b74](6bf7b74)) * **input, input-number, input-text:** Restore `autofocus`, `enter-key-mode` and `input-mode` attributes ([#9245](#9245)) ([#9306](#9306)) ([0498c6e](0498c6e)) * **list-item:** Decrease horizontal spacing between selection icon and content ([#9304](#9304)) ([0e828b6](0e828b6)) </details> <details><summary>@esri/calcite-components-angular: 2.8.1</summary> [2.8.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.8.0...@esri/calcite-components-angular@2.8.1) (2024-05-14) * **@esri/calcite-components-angular:** Synchronize components versions * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.8.1-hotfix.0 to ^2.8.1 </details> <details><summary>@esri/calcite-components-react: 2.8.1</summary> [2.8.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.8.0...@esri/calcite-components-react@2.8.1) (2024-05-14) * **@esri/calcite-components-react:** Synchronize components versions * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.8.1-hotfix.0 to ^2.8.1 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-components: 2.8.1</summary> [2.8.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.8.0...@esri/calcite-components@2.8.1) (2024-05-14) * Add type-fest as dependency due to build error ([3819688](3819688)) * **carousel:** Animate items with the same direction ([#9325](#9325)) ([6bf7b74](6bf7b74)) * **input, input-number, input-text:** Restore `autofocus`, `enter-key-mode` and `input-mode` attributes ([#9245](#9245)) ([#9306](#9306)) ([0498c6e](0498c6e)) * **list-item:** Decrease horizontal spacing between selection icon and content ([#9304](#9304)) ([0e828b6](0e828b6)) </details> <details><summary>@esri/calcite-components-angular: 2.8.1</summary> [2.8.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.8.0...@esri/calcite-components-angular@2.8.1) (2024-05-14) * **@esri/calcite-components-angular:** Synchronize components versions * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.8.1-hotfix.0 to ^2.8.1 </details> <details><summary>@esri/calcite-components-react: 2.8.1</summary> [2.8.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.8.0...@esri/calcite-components-react@2.8.1) (2024-05-14) * **@esri/calcite-components-react:** Synchronize components versions * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.8.1-hotfix.0 to ^2.8.1 </details> --- This PR was generated with [ReleasePlease](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Calcite Admin <calcite-admin@esri.com>
Related Issue: #9232
Summary
Updates carousel to wait for item animations before each slide.
Note: I'll submit a follow-up PR to refactor
openCloseComponent.onToggleOpenCloseComponent
to use the same DOM util as carousel.