fix(chip): enhance multi-select group affordance #9286
+84
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
Elijbet
added
the
pr ready for visual snapshots
Elijbet
added
pr ready for visual snapshots
Elijbet
added
pr ready for visual snapshots
jcfranco
approved these changes
May 15, 2024
| @@ -24,4 +24,6 @@ export const ICONS = { | |||
| unchecked: "circle", | |||
| checkedSingle: "circle-f", | |||
| checked: "check-circle-f", | |||
There was a problem hiding this comment.
Are checked and unchecked icons used anymore? If not, let's remove them.
|
|
||
| .multiple { | ||
| .select-icon { | ||
| padding-inline: var(--calcite-spacing-xxs); |
There was a problem hiding this comment.
Could you look at simplifying by using internal CSS props to set the appropriate spacing values? Something similar to this?
|
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
github-actions
bot
added
the
Stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #9055, #7425
Summary
Enhance
multi-selectgroup affordance.