Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add version prop to components #9280

Closed
wants to merge 7 commits into from

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented May 7, 2024

Related Issue: #8848

Summary

Adds version prop to all components.

This foregoes the suggested config approach to allow distinguishing versions between components defined by different sources.

Notes

  • Adds a custom ESLint rule to ensure all components properly set up the property
    • pending: adding JSDoc and improve placement after prop watchers
  • Each prop references a placeholder that is replaced at build-time
  • A version constant is exported through the components output target's index file.

@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label May 7, 2024
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label May 15, 2024
@jcfranco
Copy link
Member Author

Closing per #8848 (comment).

@jcfranco jcfranco closed this May 21, 2024
@jcfranco jcfranco deleted the jcfranco/8848-add-version-to-components branch May 21, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues tied to a new feature or request. Stale Issues or pull requests that have not had recent activity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant