Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(action): install cached packages on all check runs #3935

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

benelan
Copy link
Member

@benelan benelan commented Jan 13, 2022

Related Issue: #3934

Summary

The e2e and screener checks are set up to skip installing deps and running the tests on markdown-only PRs. I then ended up caching the npm deps for all actions. Apparently if you cache the deps and the action run doesn't install any, it throws an error on clean up: actions/setup-node#317 (comment)

  • I moved the install outside of the conditional.
  • Performance on all PRs that have non-markdown changes won't change
  • Markdown-only PR performance will be impacted, but it shouldn't be too bad since the packages are cached

@benelan benelan requested a review from a team as a code owner January 13, 2022 22:05
@benelan benelan self-assigned this Jan 13, 2022
@github-actions github-actions bot added this to the Sprint 01/03 - 01/14 milestone Jan 13, 2022
@github-actions github-actions bot added the chore Issues with changes that don't modify src or test files. label Jan 13, 2022
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice sleuthing! 🔍:shipit:

@benelan benelan merged commit b609c77 into master Jan 14, 2022
@benelan benelan deleted the benelan/action-cache-skip branch January 14, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issues with changes that don't modify src or test files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants