Quick Param Updates #641
Merged
Quick Param Updates #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #641 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 104 104
Lines 1528 1528
Branches 261 261
=====================================
Hits 1528 1528
Continue to review full report at Codecov.
|
jgravois
approved these changes
Dec 3, 2019
Comment on lines
+70
to
+76
| geocode({ | ||
| params: { | ||
| singleLine: "LAX", | ||
| countryCode: "USA", | ||
| outFields: ["Addr_type", "Score"] | ||
| } | ||
| }) |
There was a problem hiding this comment.
the params object is a catch all that allows anyone to pass any parameter they want. for a test like this its more helpful to exercise the curated list and confirm we are indeed also passing through 'first class citizen' parameters appropriately.
geocode({
singleLine: "LAX",
countryCode: "USA",
outFields: ["Addr_type", "Score"]
})There was a problem hiding this comment.
added another test for named parameters
| const outFieldsEncoded = encodeURIComponent( | ||
| ["Addr_type", "Score"].join(",") | ||
| ); | ||
| expect(options.body).toContain(`outFields=${outFieldsEncoded}`); |
tomwayson
approved these changes
Dec 13, 2019
This was referenced Dec 14, 2019
|
This is in v2.7.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #628 & #626