address: http://nodesecurity.io/advisories/566 #177
Merged
+12,330
−13,444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgravois
force-pushed
the
chore/bump-hoek
branch
from
42ff8a0
to
94fba37
Compare
|
rebased and confirmed that no lingering dependencies on hoek: <= had to tweak a couple istanbul ignore statements to keep coverage @ 💯 i also noticed some duplicate boilerplate in our 'karma.conf.js' related to coverage |
jgravois
force-pushed
the
chore/bump-hoek
branch
from
162f6a5
to
33ef3de
Compare
|
i cannot reproduce the slight dip in coverage coveralls is reporting locally. |
noahmulfinger
approved these changes
Apr 30, 2018
There was a problem hiding this comment.
@jgravois I can't reproduce locally either. This looks good to me!
|
@jgravois Also FYI your commit is marked as |
AFFECTS PACKAGES: @esri/arcgis-rest-auth @esri/arcgis-rest-demo-vue-with-popup
jgravois
force-pushed
the
chore/bump-hoek
branch
from
33ef3de
to
16fd1a7
Compare
nice catch eagle 👁. no clue what was going on there, but a fresh iTerm session and rebase was all it took to get my commits signed again. ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hapijs/hoek#230
request/request#2748
"gh-release" : "^3.2.1"bump request to address security vulnerability ungoldman/gh-release#72"gh-release-assets"bump to resolve security vuln ungoldman/gh-release-assets#5"karma-coveralls": "github:jgravois/karma-coveralls#..."bump dependency to address security vulnerability caitp/karma-coveralls#40"node-sass": "sass/node-sass#v4.7.0"Security issue: Prototype pollution attack(Introduced by the request@2.79.0 => hawk@3.1.3 => hoek@2.16.3) sass/node-sass#2288 (comment)"acetate": next(viabrowser-syncvialocaltunnel)fs-events appears to be a false positive fsevents/fsevents#198 (comment)
in demos/vue
"webpack-dev-server": "^3.1.3"i'll test again after a new
gh-release-assetstag lands on npm.