Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CX_HARDENING] - Audit Network Task Tests #3167

Open
9 tasks
jparr721 opened this issue May 15, 2024 · 0 comments
Open
9 tasks

[CX_HARDENING] - Audit Network Task Tests #3167

jparr721 opened this issue May 15, 2024 · 0 comments
Labels
cappuccino cappuccino-sprint2 consensus-hardening Hardening the consensus protocol and adaquate testing.

Comments

@jparr721
Copy link
Contributor

What is this task and why do we need to work on it?

The network task is quite complex, and only features two test cases. We should improve the coverage and determine if there is more work that is necessary to cover the branches. These tests also do not use the new testing framework and, as a result, there should be some effort to bring it up to spec to make maintenance easier.

What work will need to be done to complete this task?

  • - Evaluate the Vid task to determine if enough of the code is covered.
  • - Permute the inputs and verify if the tests still pass.
  • - Clean up and reduce boilerplate within the test file.
  • - Add additional tests for the various cases that were not previously handled.

Some other low-hanging fruit for this test are:

  • - Write tests for each of the conversions (handle_event)
  • - Write tests to ensure that state updates happen as expected (does it matter what order they arrive in?)

Are there any other details to include?

This one will require some care since this task is not a cookie-cutter as some of the others. This may require multiple PRs.

What are the acceptance criteria to close this issue?

  • - Test is modernized.
  • - New tests added.
  • - All tests pass.

Branch work will be merged to (if not the default branch)

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cappuccino cappuccino-sprint2 consensus-hardening Hardening the consensus protocol and adaquate testing.
Projects
None yet
Development

No branches or pull requests

1 participant