[MACRO] - CX_HARDENING - Consensus Hardening and Testing Improvements

[jparr721]

What is this task and why do we need to work on it?

This macro task encompasses the effort to improve the overall hardening of the consensus protocol and HotShot as a whole. We currently are in the situation in which our tests either do not exhaustively cover their range of inputs, don't cover the possible permutations of inputs, and do not sufficiently check for more realistic cases that we've seen in testnets.

What work will need to be done to complete this task?

Many of the testing improvements can be done in parallel, some PRs might need to be broken down to keep them small since the test framework can be bloated.

Testing Improvements

• - [CX_HARDENING] - Develop A Better Framework for Input Permutation #3161 - This one should be done first.
• - [CX_HARDENING] - Audit DA Task Tests #3160
• - [CX_HARDENING] - Modernize and Audit Vid Task Tests #3165
• - [CX_HARDENING] - Modernize and Audit View Sync Task Tests #3166
• - [CX_HARDENING] - Audit Network Task Tests #3167
• - [CX_HARDENING] - Document and Audit Testing Frameworks #3168
• - [CX_HARDENING][EASY] - Evaluate and Remove Issue Links in HotShot #3169
• - [CX_HARDENING] - Audit and Improve test_with_failures_one #3247
• - [CX_HARDENING] - Audit and Improve test_with_failures_two #3248
• - [CX_HARDENING] - Audit and Improve test_with_failures_half_f #3249
• - [CX_HARDENING] - Audit and Improve test_with_failures_f #3250
• - [CX_HARDENING] - Design the Twins Implementation #3251

Consensus Hardening Improvements

• - [CX_HARDENING] - Evaluate Usages of Consensus Global Shared State #3215

Are there any other details to include?

No response

What are the acceptance criteria to close this issue?

All tests are passing

Branch work will be merged to (if not the default branch)

No response