Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CX_HARDENING] - Modernize and Audit Vid Task Tests #3165

Closed
8 tasks
jparr721 opened this issue May 15, 2024 · 0 comments · Fixed by #3223
Closed
8 tasks

[CX_HARDENING] - Modernize and Audit Vid Task Tests #3165

jparr721 opened this issue May 15, 2024 · 0 comments · Fixed by #3223
Labels
cappuccino cappuccino-sprint2 consensus-hardening Hardening the consensus protocol and adaquate testing.

Comments

@jparr721
Copy link
Contributor

jparr721 commented May 15, 2024

What is this task and why do we need to work on it?

The Vid Task has not been modernized to use the new testing framework. It also only has a single test.

What work will need to be done to complete this task?

  • - Modernize and improve the ergonomics of the Vid task test by switching it to use the new testing framework.
  • - Evaluate the Vid task to determine if enough of the code is covered.
  • - Permute the inputs and verify if the tests still pass.
  • - Clean up and reduce boilerplate within the test file.
  • - Add additional tests for the various cases that were not previously handled.

Are there any other details to include?

We should probably have a parallel test that exists alongside the "old" test so that way we know that we aren't accidentally losing on previously covered code, but we can remove the old test before merging.

What are the acceptance criteria to close this issue?

  • - Test is modernized
  • - New tests added if needed
  • - All tests pass.

Branch work will be merged to (if not the default branch)

No response

@jparr721 jparr721 changed the title [CX_HARDENING] - Modernize and Audid Vid Task Tests [CX_HARDENING] - Modernize and Audit Vid Task Tests May 15, 2024
@jparr721 jparr721 added the consensus-hardening Hardening the consensus protocol and adaquate testing. label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cappuccino cappuccino-sprint2 consensus-hardening Hardening the consensus protocol and adaquate testing.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant