Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MCR-3609: State indicate not rates in rate cert #2448

Merged
merged 31 commits into from
May 24, 2024

Conversation

pearl-truss
Copy link
Contributor

@pearl-truss pearl-truss commented May 15, 2024

Summary

This PR

  • Replaces the "Programs this rate certification covers" field with "What rates are included in this certification?" on Rate Details, ReviewSubmit and SubmissionSummary
  • Updates the rateRevision table so that previous submissions rateProgramIDs are renamed as the deprecatedRateProgramIDs field and creates a new column called rateProgramIDs this is the same name as previous
  • Updates the statePrograms.json to include new programs that are rate programs
  • updates the Toph user to be from FL since that is a state that now has rate programs
  • Adds a new field on programSelect to determine if all programs or only contract programs should be displayed

Related issues

https://jiraent.cms.gov/browse/MCR-3609

Screenshots

Submission Summary Page
Screenshot 2024-05-15 at 4 45 26 PM

Field Validation on Rate Details
Screenshot 2024-05-14 at 11 11 29 AM
Screenshot 2024-05-14 at 11 11 35 AM

Rate Details page includes both rate and contract programs
Screenshot 2024-05-17 at 2 23 37 PM

Contract page includes only contract programs

Screenshot 2024-05-17 at 2 22 57 PM

Test cases covered

  • Program select doesnt include rate programs when contractProgramsOnly is true
  • Submission summary displays the deprecated field on submissions that have a populated rate.deprecatedRateProgramIDs field

QA guidance

  • Sign in as Toph
  • Create a new submission. Note that the Rate Details page includes the contract programs and rate programs indicated in the state program sheet
  • Rate Details displays the new wording for the field and displays an updated validation warning if left blank
  • ReviewSubmit page displays "Rates this rate certification covers" instead of "programs this rate cert covers"
  • For CMS users The SubmissioinSummary page displays "Rates this rate certification covers" instead of "programs this rate cert covers"

@macrael
Copy link
Contributor

macrael commented May 21, 2024

Why are we deprecating the old ratePrograms field? I'm still looking through the rest of the code, but I didn't think we'd need a new field for this since when a state has no rate-programs those old state-program IDs will still be valid.

What happens when a new state gets rate-programs in the future? will we have to deprecate the field again?

Copy link
Contributor

@macrael macrael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's still some confusion about what programs are supposed to be shown where, let's clarify that with design with some examples from the updated programs.json file

</Label>
<span className={styles.requiredOptionalText}>Required</span>
<span className={styles.requiredOptionalText}>
This information will be used to generate the rate name
</span>
<PoliteErrorMessage>
{showFieldErrors('rateProgramIDs')}
</PoliteErrorMessage>
<ProgramSelect
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the plan was for rate details to only show rate-programs if any rate-programs exist, otherwise show state-programs

@pearl-truss
Copy link
Contributor Author

Why are we deprecating the old ratePrograms field? I'm still looking through the rest of the code, but I didn't think we'd need a new field for this since when a state has no rate-programs those old state-program IDs will still be valid.

What happens when a new state gets rate-programs in the future? will we have to deprecate the field again?

@macrael Because of the first AC on the ticket "Historical submissions will continue to see the “Programs” field". In the figma there was a need on historic submissions to display the old field and new field separately. However, in slack today Kelsey said to replace the field completely and we'll not need to distinguish between historical and new programs on a rate.

So I agree this deprecating doesn't need to happen anymore and I'll update the database to remove it

@pearl-truss pearl-truss merged commit d1c8ac0 into main May 24, 2024
28 checks passed
@pearl-truss pearl-truss deleted the mcr-3609-state-indicate-not-rates-in-rate-cert branch May 24, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants