-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MCR-3609: State indicate not rates in rate cert #2448
MCR-3609: State indicate not rates in rate cert #2448
Conversation
…e-review into mcr-3609-state-indicate-not-rates-in-rate-cert
Why are we deprecating the old ratePrograms field? I'm still looking through the rest of the code, but I didn't think we'd need a new field for this since when a state has no rate-programs those old state-program IDs will still be valid. What happens when a new state gets rate-programs in the future? will we have to deprecate the field again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's still some confusion about what programs are supposed to be shown where, let's clarify that with design with some examples from the updated programs.json file
</Label> | ||
<span className={styles.requiredOptionalText}>Required</span> | ||
<span className={styles.requiredOptionalText}> | ||
This information will be used to generate the rate name | ||
</span> | ||
<PoliteErrorMessage> | ||
{showFieldErrors('rateProgramIDs')} | ||
</PoliteErrorMessage> | ||
<ProgramSelect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought the plan was for rate details to only show rate-programs if any rate-programs exist, otherwise show state-programs
@macrael Because of the first AC on the ticket "Historical submissions will continue to see the “Programs” field". In the figma there was a need on historic submissions to display the old field and new field separately. However, in slack today Kelsey said to replace the field completely and we'll not need to distinguish between historical and new programs on a rate. So I agree this deprecating doesn't need to happen anymore and I'll update the database to remove it |
Summary
This PR
deprecatedRateProgramIDs
field and creates a new column calledrateProgramIDs
this is the same name as previousRelated issues
https://jiraent.cms.gov/browse/MCR-3609
Screenshots
Submission Summary Page
Field Validation on Rate Details
Rate Details page includes both rate and contract programs
Contract page includes only contract programs
Test cases covered
contractProgramsOnly
is truerate.deprecatedRateProgramIDs
fieldQA guidance