MCR-4123 Fix contract actions missing on certain submissions #2445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -352,4 +353,82 @@ describe('fetchRate', () => { | |||
| '2024-02-02' | |||
| ) | |||
| }) | |||
|
|
|||
| // TEST NOT FAILING WHEN EXPECTED, NEED TO FIGURE OUT HOW TO GET RATE REVISIONS OUT OF SYNC | |||
| it.skip('returns correct linked contractRevisions, even when rate has changed', async()=>{ | |||
There was a problem hiding this comment.
I couldn't think of a way to get revisions out of sync. I wonder if anything outside the workflow happened. Feature flagging, migrations, or maybe something in the API silently errored and continued with the request.
There was a problem hiding this comment.
Thanks for checking it out. I will delete this test then... but appreciate the eyes and the QA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves an issue where a specific VAL submission (see ticket) is missing some of its related contract actions
Related issues
https://jiraent.cms.gov/browse/MCR-4123
Test cases covered
skipfor now.QA guidance