MCR-3903: Rate name does not include submission id #2444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on-id # Conflicts: # services/app-web/src/testHelpers/apolloMocks/contractPackageDataMock.ts
JasonLin0991
changed the title
JasonLin0991
commented
May 16, 2024
| } = rateFormData | ||
| const pNames = programNames(statePrograms, rateProgramIDs) |
There was a problem hiding this comment.
@pearl-truss Quick question about this. I assume that rateFormData. rateProgramIDs would contain either not a program or program and never both. Is that correct?
There was a problem hiding this comment.
@JasonLin0991 I'm sorry I'm just seeing this. I believe it should include both because some states will have a mixture
JasonLin0991
changed the title
JasonLin0991
deleted the
mcr-3903-rate-name-does-not-inlcude-submission-id
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
MCR-3903
MCR-[state]-[not a programs || programs]-[start date]-[end date]-[rate type]-[certification date]for exampleMCR-VA-PROGRAM1-PROGRAM2-20240501-20250501-CERTIFICATION-20240706.Related issues
Screenshots
The top rate is with the new rate name format. The bottom, an old rate, is a linked rate with the old rate name format retained.
Test cases covered
generateRateCertificationName.test.ts'Amendment rate test''New rate test''New rate with no dates''Amendment rate with no dates''New rate with incomplete dates''Incomplete amendment rate dates''Rate type not specified''No rate programs'QA guidance