-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MCR-4097 Fix frontend monitoring, add back error boundary fallback UI #2433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haworku
changed the title
Mcr 4097 error boundary
MCR-4097 Fix frontend monitoring, add back error boundary fallback UI
May 8, 2024
function App({ | ||
authMode, | ||
apolloClient, | ||
s3Client, | ||
}: AppProps): React.ReactElement { | ||
const environmentName = process.env.REACT_APP_STAGE_NAME || '' | ||
const isHigherEnv = ['prod', 'val', 'dev'].includes(environmentName ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
STAGE_NAME
in dev is confusingly main
, so we'll want that in this array. Really not sure why it was called main
🤷🏻♂️
mojotalantikite
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
<PageHeading/>
. This is needed because theusePage
context is not reliable if the entire app is crashing, it's too far down in the stack and will not be available in a crash.Config changes
I added 4 new config for each environment for new relic. Several are the same across all environments. I think eventually
REACT_APP_NR_LICENSE_KEY
could totally replace existingNR_LICENSE_KEY
used to set up OTEL - but decided that could switch on future PR since its a change to existing setupNew Relic Changes
mc-review-web
(for dev),mc-review-web-val
, andmc-review-web-prod
app-web errors
alert policiesRelated issues
https://jiraent.cms.gov/browse/MCR-4097
Test cases covered
No tests but made a way to manually check monitoring
QA guidance
/settings?test=crash
You should see