Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up Serverless compose #11688

Merged
merged 4 commits into from May 14, 2024
Merged

Set up Serverless compose #11688

merged 4 commits into from May 14, 2024

Conversation

gmrabian
Copy link
Contributor

@gmrabian gmrabian commented May 10, 2024

Description

Deploy with serverless compose

  • add serverless-compose.yml to define our services and their dependencies
  • add @serverless/compose package
  • remove unused packages from root and redundancies from service directories
  • remove warmup plugin
  • update serverless invoke statements to use aws lambda invoke instead
  • update variable references to use params from serverless instead of cf: outputs
  • update deploy script to run from root, using serverless compose
w/o compose with compose
Clean deploy 30:09 18:13
Re-deploy no changes 8:54 7:24
Re-deploy no changes (2) 8:08 5:43

Related ticket(s)

CMDCT-3587


How to test

No changes to app functionality or deployed env.

Compare deploy times in this branch to deploys in a test branch: https://github.com/Enterprise-CMCS/macpro-mdct-mcr/actions/runs/9036804762

deployed env: https://d327gek7pjrkws.cloudfront.net/


Pre-review checklist

  • [ ] I have added thorough tests, if necessary
  • [ ] I have updated relevant documentation, if necessary
  • I have performed a self-review of my code
  • I have manually tested this PR in the deployed cloud environment

@gmrabian gmrabian marked this pull request as ready for review May 10, 2024 20:42
@gmrabian gmrabian added the ready for review Ready for all the reviews! label May 10, 2024
Copy link

@jessabean jessabean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@gmrabian gmrabian enabled auto-merge (squash) May 14, 2024 17:50
Copy link

codeclimate bot commented May 14, 2024

Code Climate has analyzed commit c9558d6 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 95.9% (0.0% change).

View more on Code Climate.

@gmrabian gmrabian merged commit 56390a4 into main May 14, 2024
19 checks passed
@gmrabian gmrabian deleted the cmdct-3587 branch May 14, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Ready for all the reviews!
Projects
None yet
4 participants