Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update amplify to 5.3.4 #11687

Merged
merged 1 commit into from May 13, 2024
Merged

update amplify to 5.3.4 #11687

merged 1 commit into from May 13, 2024

Conversation

BearHanded
Copy link
Contributor

@BearHanded BearHanded commented May 10, 2024

Description

Upgrade amplify aws to at least 5.3.4 to close axios vulnerabilities

Related ticket(s)

CMDCT-3616


How to test

https://d286kb4ioig93.cloudfront.net/
Log in as cognito user, explore the app, make sure nothing breaks. Each access type and federated login has already been tested in carts.

Notes

Verify this works in main with real logins and iam_role auth.


Pre-review checklist

  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary
  • I have performed a self-review of my code
  • I have manually tested this PR in the deployed cloud environment

Pre-merge checklist

Review

  • Design: This work has been reviewed and approved by design, if necessary
  • Product: This work has been reviewed and approved by product owner, if necessary

Security

If either of the following are true, notify the team's ISSO (Information System Security Officer).

  • These changes are significant enough to require an update to the SIA.
  • These changes are significant enough to require a penetration test.

convert to a different template: test → val | val → prod

Copy link

codeclimate bot commented May 10, 2024

Code Climate has analyzed commit f3cfea7 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 95.9% (0.0% change).

View more on Code Climate.

@BearHanded BearHanded marked this pull request as ready for review May 10, 2024 20:21
@BearHanded BearHanded merged commit 8adced5 into main May 13, 2024
23 checks passed
@BearHanded BearHanded deleted the amplify5 branch May 13, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants