Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMDCT-3544: ILOS (Section D) #11685

Merged
merged 26 commits into from May 20, 2024
Merged

CMDCT-3544: ILOS (Section D) #11685

merged 26 commits into from May 20, 2024

Conversation

karla-vm
Copy link
Collaborator

@karla-vm karla-vm commented May 8, 2024

Description

This PR adds the second section of ILOS to the MCPAR report.

Related ticket(s)

CMDCT-3544


How to test

  • Log in as a state user
  • Create a new MCPAR report

There are a couple of cases that can occur:

  1. If you navigate directly to /mcpar/plan-level-indicators/ilos, you should see the following screen:
Screenshot 2024-05-15 at 3 41 54 PM
  1. If you add plans here /mcpar/program-information/add-plans, but no ILOS have been added, the Enter button should be disabled:
Screenshot 2024-05-15 at 3 42 57 PM
  1. If you add an ILOS here /mcpar/program-information/add-in-lieu-of-services, but no plans have been added:
Screenshot 2024-05-15 at 3 43 47 PM
  1. Finally, if you have added both plans and ILOS entities:
Screenshot 2024-05-15 at 3 45 18 PM

Notes

Updated the mcpar.json template


Pre-review checklist

  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary
  • I have performed a self-review of my code
  • I have manually tested this PR in the deployed cloud environment

Pre-merge checklist

Review

  • Design: This work has been reviewed and approved by design, if necessary
  • Product: This work has been reviewed and approved by product owner, if necessary

Security

If either of the following are true, notify the team's ISSO (Information System Security Officer).

  • These changes are significant enough to require an update to the SIA.
  • These changes are significant enough to require a penetration test.

convert to a different template: test → val | val → prod

@karla-vm karla-vm requested review from keeysnc, ntsummers1 and gmrabian and removed request for keeysnc May 15, 2024 19:46
@karla-vm karla-vm marked this pull request as ready for review May 15, 2024 19:46
gmrabian
gmrabian previously approved these changes May 15, 2024
Copy link
Contributor

@gmrabian gmrabian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code and functionality look good here! I didn't find any ways to break it.
I'm shocked codeclimate didn't complain about DrawerReportPage but maybe we are already covering the new cases? 🤔

@karla-vm karla-vm added the design review Waiting for design review label May 16, 2024
@karla-vm karla-vm requested review from gmrabian and braxex May 16, 2024 18:22
Copy link

@bangbay-bluetiger bangbay-bluetiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions

services/app-api/forms/mcpar.json Outdated Show resolved Hide resolved
@karla-vm
Copy link
Collaborator Author

Suggestions

updated! great finds, thank you 🥇

@gmrabian
Copy link
Contributor

Hey! I'm now seeing some funny behavior with the validation. If I select 'No' I don't get a green check and the button text still says "Enter". If I select 'Yes' and fill it out completely I get a check and "Edit" on the button

Screen.Recording.2024-05-20.at.10.00.30.AM.mov

@karla-vm
Copy link
Collaborator Author

Hey! I'm now seeing some funny behavior with the validation. If I select 'No' I don't get a green check and the button text still says "Enter". If I select 'Yes' and fill it out completely I get a check and "Edit" on the button

Screen.Recording.2024-05-20.at.10.00.30.AM.mov

fixed it :) thanks for finding that!!

@karla-vm karla-vm removed the design review Waiting for design review label May 20, 2024
Copy link

codeclimate bot commented May 20, 2024

Code Climate has analyzed commit 9fc3e87 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 95.9% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@gmrabian gmrabian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 😎

@karla-vm karla-vm enabled auto-merge (squash) May 20, 2024 17:34
@karla-vm karla-vm merged commit 0e513c0 into main May 20, 2024
19 checks passed
@karla-vm karla-vm deleted the ilos-3544 branch May 20, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants