-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMDCT-3544: ILOS (Section D) #11685
CMDCT-3544: ILOS (Section D) #11685
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code and functionality look good here! I didn't find any ways to break it.
I'm shocked codeclimate didn't complain about DrawerReportPage but maybe we are already covering the new cases? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestions
updated! great finds, thank you 🥇 |
Hey! I'm now seeing some funny behavior with the validation. If I select 'No' I don't get a green check and the button text still says "Enter". If I select 'Yes' and fill it out completely I get a check and "Edit" on the button Screen.Recording.2024-05-20.at.10.00.30.AM.mov |
fixed it :) thanks for finding that!! |
Code Climate has analyzed commit 9fc3e87 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 95.9% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good 😎
Description
This PR adds the second section of ILOS to the
MCPAR
report.Related ticket(s)
CMDCT-3544
How to test
There are a couple of cases that can occur:
/mcpar/plan-level-indicators/ilos
, you should see the following screen:/mcpar/program-information/add-plans
, but no ILOS have been added, the Enter button should be disabled:/mcpar/program-information/add-in-lieu-of-services
, but no plans have been added:Notes
Updated the
mcpar.json
templatePre-review checklist
Pre-merge checklist
Review
Security
If either of the following are true, notify the team's ISSO (Information System Security Officer).
convert to a different template: test → val | val → prod