Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MLR E2E Updates #11389

Merged
merged 36 commits into from Aug 1, 2023
Merged

MLR E2E Updates #11389

Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
ccdefe4
Update Overlay page to use submit function
Jul 21, 2023
38716a6
Bring down wait times in cypress tests
Jul 24, 2023
96539ff
Attempt revamp of saving entities in modal overlays
Jul 24, 2023
e3a8fac
Try turning off autosave in overlay
Jul 24, 2023
0dcf00f
Add timeout on authentication
Jul 24, 2023
20e584f
Try clearing session between logins
Jul 24, 2023
33982f9
Remove clear session
Jul 25, 2023
cb8f218
Remove clear session
Jul 25, 2023
56c0473
Remove Timeout
Jul 25, 2023
911a858
Update node version for e2e tests to use nvmrc
Jul 25, 2023
ff7a030
Update to setupnodev3
Jul 25, 2023
c2a60dc
Remove findByText for get and find in form stepdefs
Jul 25, 2023
18d3b57
Remove deprecated xpath and get rid of waitUntil in cypress
Jul 25, 2023
067d253
Update deploy for E2E tests
Jul 25, 2023
0273f76
Swap checkout in e2e test
Jul 25, 2023
564dd54
Remove node setup for e2e tests
Jul 25, 2023
5121172
Fix accessibility deployment
Jul 25, 2023
f960d1d
Add timeout to every get, wait, visit, find call
Jul 26, 2023
0fb9f7e
Remove xpath and waituntil dependencies
Jul 26, 2023
9dcfa0e
Swap out invoke function for get
Jul 26, 2023
af7c702
Reset default timeout to 4 seconds
Jul 26, 2023
7bff752
Remove individual timeouts on each cypress action
Jul 26, 2023
66803b9
Swap table button calls to get method
Jul 26, 2023
bcf6a0d
Add wait swapping between admin and user
Jul 26, 2023
9a32ebe
Turn back on autosave
Jul 27, 2023
c777343
Slightly longer wait on waiting for release
Jul 27, 2023
385246d
Slightly longer wait before setting login to make sure auth call goes…
Jul 27, 2023
7dd49ca
Add tests for submitting for the modaloverlaypage
Jul 27, 2023
6c80116
Add test for entering and closing the overlay for modaloverlay
Jul 27, 2023
a4e7175
Fix footer showing previous on first page and nowhere on mlr
Jul 28, 2023
8d588c3
Fix missing text on MLR Reporting page
Jul 29, 2023
82b20d5
Move EntityProvider to index for neater import
Jul 29, 2023
0ca73e1
Overhaul entire MLR Reporting Page
Jul 29, 2023
ef347c2
Fix up testing definitions
Jul 29, 2023
87867ef
PR cleanup
Jul 29, 2023
46995ad
Add back mobile/tablet view for modal overlay entities
Jul 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 2 additions & 6 deletions services/ui-src/src/components/overlays/EntityDetailsOverlay.tsx
View file
Open in desktop
Expand Up @@ -140,15 +140,11 @@ export const EntityDetailsOverlay = ({
autosave={true}
disabled={!userIsEndUser}
validateOnRender={validateOnRender || false}
dontReset={false}
dontReset={true}
/>
<Box sx={sx.footerBox}>
<Flex sx={sx.buttonFlex}>
<Button
onClick={() => closeOverlay()}
type="submit"
sx={sx.saveButton}
>
<Button type="submit" sx={sx.saveButton} form={form.id}>
{submitting ? (
<Spinner size="md" />
) : report?.locked ? (
Expand Down