MLR E2E Updates #11389
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,8 @@ | ||
| // element selectors | ||
| const cognitoEmailInputField = 'input[name="email"]'; | ||
| const cognitoPasswordInputField = 'input[name="password"]'; | ||
| const cognitoLoginButton = "[data-testid='cognito-login-button']"; | ||
| const myAccountButton = '[aria-label="my account"'; | ||
|
|
||
| const stateUserPassword = Cypress.env("STATE_USER_PASSWORD"); | ||
| const adminUserPassword = Cypress.env("ADMIN_USER_PASSWORD"); | ||
|
|
@@ -41,6 +42,7 @@ Cypress.Commands.add("clearSession", () => { | |
| Cypress.Commands.add("authenticate", (userType, userCredentials) => { | ||
| cy.session([userType, userCredentials], () => { | ||
| cy.visit("/"); | ||
| cy.wait(2000); | ||
| let credentials = {}; | ||
|
|
||
| if (userType && userCredentials) { | ||
|
|
@@ -65,8 +67,8 @@ Cypress.Commands.add("authenticate", (userType, userCredentials) => { | |
| throw new Error("Must specify either userType or userCredentials."); | ||
| } | ||
|
|
||
| cy.get(cognitoEmailInputField).type(credentials.email); | ||
| cy.get(cognitoPasswordInputField).type(credentials.password, { | ||
| log: false, | ||
| }); | ||
| cy.get(cognitoLoginButton).click(); | ||
|
|
@@ -76,17 +78,7 @@ Cypress.Commands.add("authenticate", (userType, userCredentials) => { | |
| * This ensures reused sessions maintain these tokens | ||
| * We expect at least three for the id, access, and refresh tokens | ||
| */ | ||
|
Comment on lines
-79
to
-90
There was a problem hiding this comment. I've updated the authentication call. It was using xpath which is deprecated, and I've removed with waitUtil and key check. Wait until wasn't in the docs from what I could find, and so I really tried to simplify the login process to be safe. That being said, calling login from the ui is an anti-pattern I guess? At least according to cypress. Some information about how we're actually supposed to call it is here but I simplified it to work with ours. |
||
| cy.wait(4500); | ||
| cy.get(myAccountButton).should("exist"); | ||
| }); | ||
| }); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,23 +18,33 @@ When("these form elements are edited:/filled:", function (dataTable) { | |
| const inputValue = row[2]; | ||
| switch (inputType) { | ||
| case "singleCheckbox": | ||
| if (inputValue == "true") { | ||
| input.check(); | ||
| input.blur(); | ||
| } else input.uncheck(); | ||
|
Comment on lines
+21
to
+24
There was a problem hiding this comment. Separating out chaining commands. You can read why from the cypress docs here: https://docs.cypress.io/guides/core-concepts/introduction-to-cypress#Chains-of-Commands |
||
| break; | ||
| case "radio": | ||
| input.check(inputValue); | ||
| input.blur(); | ||
| break; | ||
| case "checkbox": | ||
| input.check(inputValue); | ||
| input.blur(); | ||
| break; | ||
| case "dropdown": | ||
| input.select(inputValue); | ||
| input.blur(); | ||
| break; | ||
| case "repeated": | ||
| input.eq(repeatedInput); | ||
| input.clear(); | ||
| input.type(inputValue); | ||
| input.blur(); | ||
| break; | ||
| default: | ||
| input.clear(); | ||
| input.type(inputValue); | ||
| input.blur(); | ||
| break; | ||
| } | ||
| if (this.delay) cy.wait(this.delay); | ||
|
|
@@ -45,9 +55,8 @@ When("these form elements are prefilled and disabled:", (dataTable) => { | |
| dataTable.rawTable.forEach((row) => { | ||
| switch (row[1]) { | ||
| default: | ||
| cy.get(`[name='${row[0]}']`).should("have.value", row[2]); | ||
| cy.get(`[name='${row[0]}']`).should("be.disabled"); | ||
| break; | ||
| } | ||
| }); | ||
|
|
@@ -69,7 +78,8 @@ When("these form elements are prefilled:", (dataTable) => { | |
|
|
||
| When("the form is submitted", () => { | ||
| const submitButton = "[type='submit']"; | ||
| cy.get(submitButton).focus(); | ||
| cy.get(submitButton).click(); | ||
| }); | ||
|
|
||
| When("I click the {string} button", (name) => { | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the deploy updates were an attempt to get Cypress to use the same node version we use. Unfortunately, Cypress doesn't respect the node version you give it. So setting up node doesn't matter. It seems its tied to the git actions node version. Heres a thread with all sorts of other threads to dig down the rabbit hole (cypress-io/github-action#637).
That being said, we were on v1 which was no longer supported, so swapping to v3 here is a solid upgrade.