Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include test message in annotation details #357

Closed
wants to merge 4 commits into from

Conversation

EnricoMi
Copy link
Owner

@EnricoMi EnricoMi commented Oct 4, 2022

Currently, either the case message or its content is provided as annotation details. This considers both, if the content does not repeat the message.

Fixes #355.

if sys.platform == 'win32':
file.close()

options = dict(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hardcoded_password_funcarg: Possible hardcoded password: 'token'


ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.


Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

Test Results (setup-python)

       66 files  ±       0         66 suites  ±0   32m 9s ⏱️ + 7m 6s
     372 tests +     69       372 ✔️ +     69      0 💤 ±0  0 ±0 
24 552 runs  +4 554  24 048 ✔️ +4 554  504 💤 ±0  0 ±0 

Results for commit 50be15e. ± Comparison against base commit 60624fd.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

Test Results (Test File)

97 tests  ±0   80 ✔️ ±0   3m 25s ⏱️ ±0s
  1 suites ±0   17 💤 ±0 
  1 files   ±0     0 ±0 

Results for commit 50be15e. ± Comparison against base commit 60624fd.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

Test Results (macOS python 3.6)

       66 files  ±       0         66 suites  ±0   32m 9s ⏱️ + 7m 6s
     372 tests +     69       372 ✔️ +     69      0 💤 ±0  0 ±0 
24 552 runs  +4 554  24 048 ✔️ +4 554  504 💤 ±0  0 ±0 

Results for commit 50be15e. ± Comparison against base commit 60624fd.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

Test Results (Dockerfile)

       66 files  ±       0         66 suites  ±0   32m 9s ⏱️ + 7m 6s
     372 tests +     69       372 ✔️ +     69      0 💤 ±0  0 ±0 
24 552 runs  +4 554  24 048 ✔️ +4 554  504 💤 ±0  0 ±0 

Results for commit 50be15e. ± Comparison against base commit 60624fd.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

Test Results (Test Files)

     66 files  ±0         6 errors  357 suites  ±0   1h 6m 4s ⏱️ ±0s
1 681 tests ±0  1 396 ✔️ ±0    71 💤 ±0  207 ±0  7 🔥 ±0 
1 928 runs  ±0  1 589 ✔️ ±0  106 💤 ±0  225 ±0  8 🔥 ±0 

For more details on these parsing errors, failures and errors, see this check.

Results for commit 50be15e. ± Comparison against base commit 60624fd.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

Test Results (Docker Image)

       66 files  ±       0         66 suites  ±0   32m 9s ⏱️ + 7m 6s
     372 tests +     69       372 ✔️ +     69      0 💤 ±0  0 ±0 
24 552 runs  +4 554  24 048 ✔️ +4 554  504 💤 ±0  0 ±0 

Results for commit 50be15e. ± Comparison against base commit 60624fd.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

Test Results (Linux python 3.6)

       66 files  ±       0         66 suites  ±0   32m 9s ⏱️ + 7m 6s
     372 tests +     69       372 ✔️ +     69      0 💤 ±0  0 ±0 
24 552 runs  +4 554  24 048 ✔️ +4 554  504 💤 ±0  0 ±0 

Results for commit 50be15e. ± Comparison against base commit 60624fd.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

Test Results (macOS 12 python installed)

       66 files  ±       0         66 suites  ±0   32m 9s ⏱️ + 7m 6s
     372 tests +     69       372 ✔️ +     69      0 💤 ±0  0 ±0 
24 552 runs  +4 554  24 048 ✔️ +4 554  504 💤 ±0  0 ±0 

Results for commit 50be15e. ± Comparison against base commit 60624fd.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

Test Results (macOS python installed)

       66 files  ±       0         66 suites  ±0   32m 9s ⏱️ + 7m 6s
     372 tests +     69       372 ✔️ +     69      0 💤 ±0  0 ±0 
24 552 runs  +4 554  24 048 ✔️ +4 554  504 💤 ±0  0 ±0 

Results for commit 50be15e. ± Comparison against base commit 60624fd.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

Test Results (Linux python installed)

       66 files  ±       0         66 suites  ±0   32m 9s ⏱️ + 7m 6s
     372 tests +     69       372 ✔️ +     69      0 💤 ±0  0 ±0 
24 552 runs  +4 554  24 048 ✔️ +4 554  504 💤 ±0  0 ±0 

Results for commit 50be15e. ± Comparison against base commit 60624fd.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

Test Results (Linux 22.04 python installed)

       66 files  ±       0         66 suites  ±0   32m 9s ⏱️ + 7m 6s
     372 tests +     69       372 ✔️ +     69      0 💤 ±0  0 ±0 
24 552 runs  +4 554  24 048 ✔️ +4 554  504 💤 ±0  0 ±0 

Results for commit 50be15e. ± Comparison against base commit 60624fd.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

Test Results (Windows python installed)

       66 files  ±       0         66 suites  ±0   32m 9s ⏱️ + 7m 6s
     372 tests +     69       372 ✔️ +     69      0 💤 ±0  0 ±0 
24 552 runs  +4 554  24 048 ✔️ +4 554  504 💤 ±0  0 ±0 

Results for commit 50be15e. ± Comparison against base commit 60624fd.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

Test Results (reference)

       66 files  ±       0         66 suites  ±0   32m 9s ⏱️ + 7m 6s
     372 tests +     69       372 ✔️ +     69      0 💤 ±0  0 ±0 
24 552 runs  +4 554  24 048 ✔️ +4 554  504 💤 ±0  0 ±0 

Results for commit 50be15e. ± Comparison against base commit 60624fd.

♻️ This comment has been updated with latest results.

finally:
if sys.platform == 'win32':
os.unlink(file.name)
settings = get_settings(dict(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hardcoded_password_funcarg: Possible hardcoded password: '********'


ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.


Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

@EnricoMi
Copy link
Owner Author

Fixed in #358.

@EnricoMi EnricoMi closed this Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nunit test failure message is missing
1 participant