New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include test message in annotation details #357
Conversation
python/test/test_junit.py
Outdated
if sys.platform == 'win32': | ||
file.close() | ||
|
||
options = dict( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hardcoded_password_funcarg: Possible hardcoded password: 'token'
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
Command | Usage |
---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
Test Results (Test Files) 66 files ±0 6 errors 357 suites ±0 1h 6m 4s ⏱️ ±0s For more details on these parsing errors, failures and errors, see this check. Results for commit 50be15e. ± Comparison against base commit 60624fd. ♻️ This comment has been updated with latest results. |
Test Results (macOS 12 python installed) 66 files ± 0 66 suites ±0 32m 9s ⏱️ + 7m 6s Results for commit 50be15e. ± Comparison against base commit 60624fd. ♻️ This comment has been updated with latest results. |
Test Results (Linux 22.04 python installed) 66 files ± 0 66 suites ±0 32m 9s ⏱️ + 7m 6s Results for commit 50be15e. ± Comparison against base commit 60624fd. ♻️ This comment has been updated with latest results. |
Test Results (Windows python installed) 66 files ± 0 66 suites ±0 32m 9s ⏱️ + 7m 6s Results for commit 50be15e. ± Comparison against base commit 60624fd. ♻️ This comment has been updated with latest results. |
53f77c2
to
9ec62cf
Compare
9ec62cf
to
9f49868
Compare
finally: | ||
if sys.platform == 'win32': | ||
os.unlink(file.name) | ||
settings = get_settings(dict( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hardcoded_password_funcarg: Possible hardcoded password: '********'
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
Command | Usage |
---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
Fixed in #358. |
Currently, either the case message or its content is provided as annotation details. This considers both, if the content does not repeat the message.
Fixes #355.