Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide optional monospace PR comment layout #46

Open
EnricoMi opened this issue Oct 29, 2020 · 1 comment
Open

Provide optional monospace PR comment layout #46

EnricoMi opened this issue Oct 29, 2020 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@EnricoMi
Copy link
Owner

In #26 we have discussed how a monospace comment could look like. Here is a suggestion:

521 suites (-60) in 4h 24m 19s (-5m 23s)
508 tests   (+1)
482 success (+1)
 26 skipped (±0)
  0 failed  (±0)
9 876 runs    (-1 190)
7 873 success (-  896)
2 003 skipped (-  294)
    0 failed  (±    0)
results for commit e826078 ± comparison against base commit 3fefb1a

and without runs:

521 suites (-60) in 4h 24m 19s (-5m 23s)
508 tests   (+1)
482 success (+1)
 26 skipped (±0)
  0 failed  (±0)
results for commit e826078
± comparison against base commit 3fefb1a

Implement that as an optional comment layout.

@EnricoMi EnricoMi added the enhancement New feature or request label Oct 29, 2020
@EnricoMi EnricoMi changed the title Provide option to comment on PR in monospace Provide optional monospace PR comment layout Oct 29, 2020
@Fox32
Copy link

Fox32 commented May 25, 2021

This idea looks great, looking forward to it! I also like your thoughts on the thousands separator in the PR, space should be the least confusing one.

@EnricoMi EnricoMi added the good first issue Good for newcomers label May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants