Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A table layout? #146

Closed
max-sixty opened this issue Jun 26, 2021 · 3 comments
Closed

A table layout? #146

max-sixty opened this issue Jun 26, 2021 · 3 comments
Labels
good first issue Good for newcomers

Comments

@max-sixty
Copy link

We just got this working on xarray: pydata/xarray#5537. It looks really promising, thanks for creating it!

Currently the text doesn't align that well — what do you think about making a markdown table, or using a monospaced section?

image

@EnricoMi
Copy link
Owner

EnricoMi commented Jul 5, 2021

The monospaced bit is discussed in #46. Tables turned out to be rendered with a very large margin, which I could not get look appealing. I am happy to discuss markdown proposals. You can hit the 'Edit' button on the comment created by the action and try to sketch out some better layout.

The particular problem in your example is that the 1s have a different width than all other digits. This is not the case on other operating systems and browsers so numbers align there perfect to the pixel:

grafik

@EnricoMi EnricoMi added the good first issue Good for newcomers label Jul 5, 2021
@max-sixty
Copy link
Author

Thanks @EnricoMi . I had a go at a table layout, but on reflection it doesn't actually fit that well — it's not really a traditional rows & columns layout. The most promising I could think of is to reorient to pivot it to "Old" and "New" as columns, but even that doesn't capture the current first column.

#46 looks good!

It's surprising mine displays differently! I'm using firefox on Mac, and I get the same results with Chrome on Mac. I don't think I have any idiosyncratic settings.

I'll close this in the meantime. Thanks.

@EnricoMi
Copy link
Owner

EnricoMi commented Jul 8, 2021

@max-sixty thanks for giving this some thoughts, I find this one really tricky.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants