Skip to content
This repository has been archived by the owner on Oct 2, 2022. It is now read-only.

Travis to workflows #200

Closed
wants to merge 4 commits into from

Conversation

Codex-
Copy link

@Codex- Codex- commented Nov 16, 2021

What did you implement:

I came across this issue which is blocking my usage of craco which now depends on cosmiconfig. I read that the PR won't be accepted until the travis-ci porting to Github Actions was completed, so this serves as a foundation to complete that.

How did you implement it:

I read the original travis-ci config and ported it to three workflows which separates the concerns:

  • Build
    • Runs on supported LTS Node version, 12, 14, 16.
    • build
    • lint
    • test
  • Coverage
    • Runs on LTS Node
    • test
  • Release
    • Runs on LTS Node
    • build
    • semantic-release

How can we verify it:

Check the workflow runs, these can be re-run until things work.

Secrets need to be added for:

  • SLACK_WEBHOOK (if you plan on using it, otherwise can just remove this).
  • CC_TEST_REPORTER_ID for code climate coverage.
  • Release things:
    • GITHUB_TOKEN
    • NPM_TOKEN

Releasing will be tricky to test with it being automatic and run on master only, due to the nature of secrets and such, I can't assist here (but would if I could).

Let me know what you think, and what you would like to change, I'm happy to try and facilitate these changes where I can.

Tasks:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@Codex-
Copy link
Author

Codex- commented Nov 30, 2021

Unfortunately, it seems as though this repository and package aren't going to be maintained going forward, with the sale of Endemol Shine Group.

I have rewritten and addressed some existing issues (#134 #147 #155) and published a drop-in replacement:
https://www.npmjs.com/package/cosmiconfig-typescript-loader

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant