Modification custom logo #1331
Open
Modification custom logo #1331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this modification the objective is to be more precise on the PNG part. I made two parts, one for the tuleap server and one for the docker. It’s more useful to do this than to have generic information on the PNG part. I explain in details how to add the two PNG files in the tuleap server and in the docker. I think it’s important to be clear on those points to facilitate the user in his attempt to have a new logo on his page.
vaceletm
requested changes
Jan 31, 2024
Comment on lines
172
to
182
| ``docker run -v directory_files/:name_of_directory -v name_volume:/tuleap-data -t -i alpine sh`` | ||
|
|
||
| * directory_files : it’s corresponding of where you put your two logos in your host. | ||
| * name_of_directory : it’s the name of your directory in your container. You can put what you want. | ||
| * name_volume : it’s the name of your volume that you are using for this modification. You can check all your volumes name with : ``docker volume ls`` | ||
| * alpine : we decide to put alpine because it’s a light image but you can choose an another one. | ||
| * sh : it’s launching a bash environment. | ||
|
|
||
| Now you are going to remove the two existing logos in ``/tuleap-data/var/lib/tuleap/images`` | ||
|
|
||
| When this is done you can go exit the bash environment. |
There was a problem hiding this comment.
- It should work with only one step if you use
cp -fin the command bellow (that will override the target file) - I suggest that, instead of
name_of_directory, you enfore ce name, for instance/pictures, this way, it's easy for admin to copy/paste, it's one less thing to change - You don't need to to precise what
alpineis
There was a problem hiding this comment.
I understand your point. I will do one command, but in other hand I will precise what the command does.
|
|
||
| And now you are going to copy your two png files between your host and the tuleap docker. | ||
|
|
||
| ``docker run -v directory_files/:name_of_directory -v name_volume:/tuleap-data -t -i cp name_of_directory/organization_logo.png /tuleap-data/var/lib/tuleap/images`` |
There was a problem hiding this comment.
- Please add
--rmtodocker runarguments, you don't need to keep the container used for cp - you don't need
-tand-ihere because there is no interactions - I would suggest to copy using
organisation_logo*.pngso it copies all the files at once
There was a problem hiding this comment.
The review above is a part of this review.
|
|
||
| Do the same for ``organization_logo_small.png`` | ||
|
|
||
| Now you can start docker with : ``docker compose up -d`` |
There was a problem hiding this comment.
A restart of web container should be enough
There was a problem hiding this comment.
Yes, for sure it will be faster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this modification the objective is to be more precise on the PNG part. I made two parts, one for the tuleap server and one for the docker. It’s more useful to do this than to have generic information on the PNG part. I explain in details how to add the two PNG files in the tuleap server and in the docker. I think it’s important to be clear on those points to facilitate the user in his attempt to have a new logo on his page.