1793 kill liuggio #144
Merged
1793 kill liuggio #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonHeimberg
suggested changes
May 18, 2020
| } | ||
|
|
||
| /** | ||
| * @expectedException \InvalidArgumentException |
There was a problem hiding this comment.
this annotation is deprecated: sebastianbergmann/phpunit#3332
the reason is written here: https://thephp.cc/news/2016/02/questioning-phpunit-best-practices
src/FileFormat/ExcelConverter.php
Outdated
| * @param string $filename filename to give to the download | ||
| * @param string $format format of write (like Excel2007) | ||
| * @param string $contentType mime content type | ||
| * @param PhpOffice\PhpSpreadsheet\Spreadsheet $spreadsheet Excel object to create the download from |
There was a problem hiding this comment.
There is no need for the namespace. The class has a use statement, and this is used in phpdoc as well.
| @@ -94,40 +72,47 @@ public function fromHtml($html, $selector = null) | |||
|
|
|||
| $tmpFile = $this->getTempHtmlFile($htmlStr); // as temporary file because it must have a filename | |||
|
|
|||
| return $this->getExcelService()->createPHPExcelObject($tmpFile['path']); | |||
| return IOFactory::load($tmpFile['path']); | |||
src/FileFormat/ExcelConverter.php
Outdated
| $writer->save('php://output'); | ||
| }, | ||
| 200, | ||
| [] |
There was a problem hiding this comment.
Ah, I see. The headers are set later. So it is fine. We could skip this arg entirely ([] is the default).
| @@ -1,104 +0,0 @@ | |||
| <?php | |||
There was a problem hiding this comment.
is not used in pa nor in tm, so 👍 to delete it
Use class name in phpdoc, because there is a use statement for it. Set a valid spreadsheet type in phpdoc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://github.com/EmchBerger/projectassistant/issues/1793
Remove Liuggio/ExcelBundle, which requires the abandoned PHPOffice/PHPExcel bundle.
Remove ExcelReader service, which is not used.