Compatibility updates for Ember 2.12 #21
Conversation
Note that I cannot update to ember 2.12 just yet until there is a resolution for emberjs/ember.js#15013
For now, I am skipping the three tests that assert that errors are thrown, until I can find a resolution for emberjs/ember.js#15013 Additionally, I fixed the _lookupFactory deprecation in favor of factoryFor Also, removed a few jshint pragmas
this requires adding ember-cli-string-helpers, since it was refactored out and tracked separately as of 2.x
|
This is awesome! Thank you so much! I'm going to add you as a contributor to this repo so you can merge it when you think it's ready. |
|
Likewise! This addon is fantastic, and a staple for my apps. Since there were API changes (e.g. |
Very happy. Which helpers do you use?
Yeah. good idea. |
Primarily
1.0.0 or 0.5.0 ? |
|
Let's go for 0.5.0. Can you please remove |
|
Sure thing. |
This branch started as a base of your 2.9 compatibility branch.
The biggest item to note is that I had to skip 3 tests in
r-get-test.jsdue to this issue: emberjs/ember.js#15013Other than that, the updates are related to dependency bumps, as well as the change to support
factoryFor.